Quote Bug - Printable Version
-Shoutbox (https://shoutbox.menthix.net)
+-- Forum: MsgHelp Archive (/forumdisplay.php?fid=58)
+--- Forum: General (/forumdisplay.php?fid=11)
+---- Forum: Forum & Website (/forumdisplay.php?fid=13)
+----- Thread: Quote Bug (/showthread.php?tid=58875)
Quote Bug by Jhrono on 04-29-2006 at 10:39 AM
Look at this :
code:
[quote=[url=http://en.wikipedia.org/wiki/Dynamic_IP#IP_address_allocation]Wikipedia[/url]
TEXT TEXT TEXT
[/quote]
Produces :
quote:
Originally posted by [url=http://en.wikipedia.org/wiki/Dynamic_IP#IP_address_allocatio[b
n][/b]Wikipedia[/url]
TEXT TEXT TEXT
For some reason, it doesn't display the [url=] closing bracket, hence, the problem.
RE: Quote Bug by zaher1988 on 04-29-2006 at 11:08 AM
quote:
Originally posted by [url=http
hii[/url]]hiii
That's a known bug, read here for more info.
Regards
RE: Quote Bug by Mike on 04-29-2006 at 12:20 PM
Don't know if you can call this a bug really :
When using [quote] the name is automaticly enclosed in [noparse] tags, so if someone quotes someone who has "]" in his/her username, the quote parser, won't get confused and think that the quote ends there.
That's why the url tag wont work there, because it's not parsed.
Edit: By looking again into it, it seems that the name is not enclosed in noparse tags 
RE: Quote Bug by zaher1988 on 04-29-2006 at 06:44 PM
That is a bug !! because some people may have [ or ] in their username which will cause some troubles.
If you have read the url i have posted, it currently under discussion on mybb community, and the team is trying to find a fix for that.
Many ideas were presented, however i'm not sure what fix will be chosen.
The problem as you havementioned is in the ], that's so abvious, but now what's important is to find an escape falling in this trap. Umm if you look at the code you see how things go in the quoting process.
code:
"#\[ quote=(?:"|\"|')?(.*?)[\"']?(?:"|\"|')?\](.*?)\[\/quote\ ]#si"
One of the best ways is to add quotation to the user name
[ quote='zaher1988' ]
Many Regards
RE: Quote Bug by RaceProUK on 05-01-2006 at 12:14 AM
I've noticed this before when quoting [MR]. I reported it (ages ago now), but nothing was ever done. TBH, it's easy to fix: add support for stacking [ and ].
RE: Quote Bug by Lou on 05-01-2006 at 12:34 AM
quote:That does not work unless the code is modified. Believe me I have tried. No matter what, the ] in the name ends the tag.
Originally posted by zaher1988
[ quote='zaher1988' ]
RE: Quote Bug by zaher1988 on 05-02-2006 at 12:19 PM
I added spaces just not to have a quotation of what i said
i'm referring to the '
regards
RE: RE: Quote Bug by Matti on 05-02-2006 at 05:36 PM
quote:That doesn't seem to work either. Like .Lou said, the code just searches for the next ] and there ends the name. The only work-around I see is by using:
Originally posted by zaher1988
[ quote='zaher1988' ]
code:since that's what it generates: pure BBCode. You can just emulate it and everything works just fine.
[quote][i]Originally posted by [MR][/i]
Text [MR] said...[/quote]
I know it's not easy when you want to reply fast, but it's the only way I see to fix this
RE: Quote Bug by WDZ on 05-02-2006 at 05:43 PM
quote:Because I haven't added support for it yet, but I plan to.
Originally posted by Mattike
That doesn't seem to work either.
Then [quote="[MR]"] should work fine.
RE: Quote Bug by RaceProUK on 05-02-2006 at 07:48 PM
Will the QQ default to adding the quote marks?
RE: Quote Bug by zaher1988 on 05-02-2006 at 08:16 PM
Guys reread what i have said
quote:
Originally posted by zaher1988
Many ideas were presented, however i'm not sure what fix will be chosen.
quote:
Originally posted by zaher1988
One of the best ways is to add quotation to the user name
[ quote='zaher1988' ]
This is an idea for the fix, and it wont work unless you edit the BBcode function
!As i have said, many ideas were provided, but this way was most realistic, and i hope it will be included in mybb 1.2
regards
RE: Quote Bug by Matti on 05-03-2006 at 03:06 PM
quote:Ooh...
Originally posted by WDZ
Because I haven't added support for it yet, but I plan to.
quote:
Originally posted by zaher1988
Guys reread what i have said
quote:That sounds good, but don't we have to decline the use of " in the names then? Since "(AaRoN)" would result in (AaRoN) then...
Originally posted by WDZ
Then [quote="[MR]"] should work fine.
RE: Quote Bug by WDZ on 05-03-2006 at 03:28 PM
quote:Hmm... I'll rename him.
Originally posted by Mattike
That sounds good, but don't we have to decline the use of " in the names then? Since "(AaRoN)" would result in (AaRoN) then...
He registered before I banned quote characters in usernames.
RE: Quote Bug by WDZ on 05-04-2006 at 04:32 AM
quote:
Originally posted by Wikipedia
TEXT TEXT TEXT
quote:Well, that seems to work.
Originally posted by [MR]
what would [MR] say that's worth quoting? I dunno...
Also, from now on, the Quick Quote will wrap the username in quote characters if it contains the ] character.
RE: Quote Bug by zaher1988 on 05-04-2006 at 05:23 AM
gr8!
remember guys, put the username between " "
regards
RE: Quote Bug by Weyzza on 05-04-2006 at 05:27 AM
quote:It works without quotation marks, too.
Originally posted by zaher1988
gr8!
remember guys, put the username between " "
regards
Edit: should have said it clearer
Names without [] don't need quotation marks.
RE: Quote Bug by John Anderton on 05-04-2006 at 08:26 AM
quote:Or we could ignore his misquotes/tell him to change his name to MR
Originally posted by WDZ
quote:Because I haven't added support for it yet, but I plan to.
Originally posted by Mattike
That doesn't seem to work either.
Then [quote="[MR]"] should work fine.
But that'd probably be the
phpbb uses " " and it sucks
RE: Quote Bug by zaher1988 on 05-04-2006 at 09:24 AM
quote:
quote:
--------------------------------------------------------------------------------
Originally posted by zaher1988
gr8!
remember guys, put the username between " "
regards
--------------------------------------------------------------------------------
It works without quotation marks, too.
no it doesn't
Without " "
quote:
Originally posted by [name
]hiii
with " "
quote:
Originally posted by [name]
hii
regards
RE: Quote Bug by WDZ on 05-04-2006 at 01:58 PM
quote:Why does it suck?
Originally posted by John Anderton
phpbb uses " " and it sucks
The quotes are completely optional, and you only need to use them when the username contains a closing bracket character.
RE: Quote Bug by Matti on 05-04-2006 at 04:22 PM
quote:Great job WDZ!
Originally posted by the Messenger Plus! Multi-Format Colors FAQ
This is very handy when quoting a website!
RE: Quote Bug by zaher1988 on 05-04-2006 at 05:42 PM
well my fix for that error oblige users to put quotes even if there is no brackets.
RE: Quote Bug by Plik on 05-04-2006 at 05:46 PM
quote:Which is why wdz's is better than yours
Originally posted by zaher1988
well my fix for that error
RE: Quote Bug by John Anderton on 05-04-2006 at 05:52 PM
quote:Exactly. The quotes look aweful and dodgy. We'd rather stand the erroroneous quotes or ask the person to change his name slightly
Originally posted by Plik
quote:Which is why wdz's is better than yours
Originally posted by zaher1988
well my fix for that error
RE: Quote Bug by zaher1988 on 05-04-2006 at 05:56 PM
noo!! wait, quotes will not appear heheh
RE: Quote Bug by John Anderton on 05-04-2006 at 06:02 PM
quote:I meant that the compulsary ones suck.
Originally posted by WDZ
quote:Why does it suck?
Originally posted by John Anderton
phpbb uses " " and it sucks
The quotes are completely optional, and you only need to use them when the username contains a closing bracket character.
I dont want to type [quote="WDZ"] everytime. I prefer the traditional [quote=WDZ]
Like you said the quotes should be optional. I posted my post in reply to Zaheers post and not yours
Tbh the optional quotes are the best. I hope it will be auto included on encountering a name with the closing square bracket "]"
Good job WDZ
RE: Quote Bug by WDZ on 05-04-2006 at 06:46 PM
quote:Ah, yeah, I agree.
Originally posted by John Anderton
I meant that the compulsory ones suck.
quote:Yep... read what I said earlier in the thread...
Tbh the optional quotes are the best. I hope it will be auto included on encountering a name with the closing square bracket "]"
quote:
Originally posted by WDZ
Also, from now on, the Quick Quote will wrap the username in quote characters if it contains the ] character.
RE: Quote Bug by zaher1988 on 05-04-2006 at 07:25 PM
hehe i know that it is not a realible fix, especially that is compulsory in all cases.
Hopefully MyBB 1.2 will come with an automated wrap for usernames containing ], so that users will not have to enter them manually. But for now there is no way but to do that.
Making it an automated process isn't a little code that you change, it will need somehow a total modification for the the quote function.
Regards