quote:

---

Originally posted by The Debug Window
Error: .
       Line: 135. Code: -2147418113.
Function OnEvent_Initialize returned an error. Code: -2147352567

---

code:

---

WriteRegistry("OldPSM",Messenger.MyPersonalMessage);

---

code:

---

function WriteRegistry(key, value){
Debug.Trace("WRITE REGISTRY - "+key + ": "+value);
return new ActiveXObject("WScript.Shell").RegWrite(MsgPlus.ScriptRegPath + Messenger.MyEmail + "\\" + key, value, "REG_SZ");
}

---

This is caused since Messenger.MyEmail is undefined. It works when you re-enable it since you're logged in and the email is set. Therefore, try this:

code:

---

function OnEvent_Initialize(MessengerStart) {
   if(MessengerStart && Messenger.MyStatus > 1) {
       OnEvent_SigninReady(Messenger.MyEmail); //Call the event like a normal function
   }
}
function OnEvent_SigninReady(Email) {
   //Original code for OnEvent_Initialize goes here
}

---

I suggest reg functions like:

code:

---

function WriteRegistry(key, value)
{
    var Shell = new ActiveXObject("WScript.Shell");
    try {
        return Shell.RegWrite(MsgPlus.ScriptRegPath + Messenger.MyEmail + "\\" + key, value);
    } catch {
        return false;
    }
}


function ReadRegistry(key)
{
    var Shell = new ActiveXObject("WScript.Shell");
    try {
        return Shell.RegRead(MsgPlus.ScriptRegPath + Messenger.MyEmail + "\\" + key);
    } catch {
        return false;
    }
}

function RemoveRegistry(key)
{
     var Shell = new ActiveXObject("Wscript.Shell");
    try {     
        return Shell.RegDelete(MsgPlus.ScriptRegPath + Messenger.MyEmail + "\\" + key);
    } catch {
        return false;
    }
}

---

Thankyou both. Just changed the code and I'm testing it out and I've sent it to a few others to try, but it seems to work (apart from still causing an OnEvent_Initialize error in the debug window)

EDIT: Thought it was working, but it still throws an error at the same line, meaning I can't read any of the settings for the script... It only starts working when it's re-renabled... Any ideas?

Mattike has got the right idea, but if I'm not mistaken, shouldn't it be:

code:

---

function OnEvent_Initialize(MessengerStart) {
   if(!MessengerStart && Messenger.MyStatus > 1) {
       OnEvent_SigninReady(Messenger.MyEmail); //Call the event like a normal function
   }
}
function OnEvent_SigninReady(Email) {
   //Original code for OnEvent_Initialize goes here
}

---

quote:

---

Originally posted by Mattike

code:

---

if(MessengerStart && Messenger.MyStatus > 1)

---

---

quote:

---

Originally posted by phalanxii
but if I'm not mistaken, shouldn't it be:

code:

---

function OnEvent_Initialize(MessengerStart) {
   if(!MessengerStart && Messenger.MyStatus > 1) {
       OnEvent_SigninReady(Messenger.MyEmail); //Call the event like a normal function
   }
}
function OnEvent_SigninReady(Email) {
   //Original code for OnEvent_Initialize goes here
}

---

That way, OnEvent_SigninReady executes when a) the script is enabled when Messenger is signed in and b) when you sign in to Messenger. Also, if you don't need any details from contacts, you can use OnEvent_Signin instead, as this will give the same result, but a lot earlier.

---

code:

---

function OnEvent_Initialize(MessengerStart) {
   if(Messenger.MyStatus > 0) {
       OnEvent_SigninReady(Messenger.MyEmail);
   }
}
function OnEvent_SigninReady(Email) {
   //Original code for OnEvent_Initialize goes here
}

---

Ah yeah, sorry about that. I forgot about the status being 0 when you're not signed (so the code isn't executed). What I actually meant was:

code:

---

function OnEvent_Initialize(MessengerStart) {
   if(!MessengerStart) {
       OnEvent_SigninReady(Messenger.MyEmail); //Call the event like a normal function
   }
}
function OnEvent_SigninReady(Email) {
   //Original code for OnEvent_Initialize goes here
}

---

quote:

---

Originally posted by phalanxii
Mattike has got the right idea, but if I'm not mistaken, shouldn't it be:

code:

---

...

---

---

quote:

---

Originally posted by phalanxii
I don't think my code is wrong either ... although your code works just as well.

---

quote:

---

Originally posted by phalanxii
I would also use OnEvent_Signin instead of OnEvent_SigninReady because it is called a lot earlier. Though OnEvent_Signin is called when not all information is available, for SpunkyLoveMuff's purpose of writing settings into the registry, contact information is not required (if it is, then use OnEvent_SigninReady ).

---

quote:

---

Originally posted by phalanxii
Ah yeah, sorry about that. I forgot about the status being 0 when you're not signed (so the code isn't executed). What I actually meant was:

code:

---

function OnEvent_Initialize(MessengerStart) {
   if(!MessengerStart) {
       OnEvent_SigninReady(Messenger.MyEmail); //Call the event like a normal function
   }
}
function OnEvent_SigninReady(Email) {
   //Original code for OnEvent_Initialize goes here
}

---

Cookie's code works exactly the same, so it doesn't really matter.

---

quote:

---

Originally posted by Mattike
(...)
So, the only way it should work is by using both !MessengerStart and Messenger.MyStatus > 0.

---

Thanks for the help guys. Cookie's solution appears to have worked

I'm reading a comma seperated list from the registry and reading it into an array and then placing it into a List View box thingy   This needs to be done ASAP as the window is opened when the script starts... (it then gets hidden until it's needed)

Like I said, if(Messenger.MyStatus > 0) seems to work for what I want at the moment... Thanks

no problem...

PS: do not use "Messenger.MyEmail" to store info in the registry, use "Messenger.MyUserId" instead... security reasons!

PS2: anyways

quote:

---

Originally posted by SpunkyLoveMuff
I'm reading a comma seperated list from the registry and reading it into an array and then placing it into a List View box thingy   This needs to be done ASAP as the window is opened when the script starts... (it then gets hidden until it's needed)

---

I should go back and edit the Read/Write functions for that then as I used ones I found on the forums

I did see you mention that in another thread, but totally forgot about editing scripts I've made already...

quote:

---

Originally posted by Mattike
4. You have imported the script while you are signed out:
   OnEvent_Initialize is called.
   MessengerStart is false, so !MessengerStart is true.
   The if statement in OnEvent_Initialize is executed.
   OnEvent_Signin is called.
   Messenger.MyEmail is undefined (you are signed out).
     TUUT! Error!

---

quote:

---

Originally posted by CookieRevised
Open Messenger, before signing in, restart the script. You'll see that with your method (if(!MessengerStart)) your script will end in an error, while mine (if(Messenger.MyStatus > 0)) doesn't.

---

code:

---

---------------------------
Messenger Plus! Live
---------------------------
You must be signed in before you can import new scripts.
---------------------------
OK   
---------------------------

---

code:

---

---------------------------
Messenger Plus! Live
---------------------------
You must be signed-in to get access to your preferences.
---------------------------
OK   
---------------------------

---

scripts can start before you are signed in from what I've noticed, it doesnt matter if you can't import them when not signed in...

quote:

---

Originally posted by phalanxii

quote:

---

Originally posted by CookieRevised
Open Messenger, before signing in, restart the script. You'll see that with your method (if(!MessengerStart)) your script will end in an error, while mine (if(Messenger.MyStatus > 0)) doesn't.

---

Yes, true, that theoretically the script is different if !MessengerStart is used, but practically, there is no difference. Why? Because you can only import/restart/enable a script when a) WLM is open and b) you are signed in. Therefore, Cookie's scenarios 2 and 5 (and Mattike's scenario 4) don't exist and there is no error.
(...)
Please tell me if I'm wrong about this, because I'm one of those many people who use that method in their scripts.

---

Oh crap, that's devious...

I just figured it out:

1. Sign in.
2. Open your preferences.
3. Sign out.
4. Change your script preferences...

Is that a bug or what? I guess I'll need to fix all my scripts! (Sorry everybody, you were all right! )

EDIT: And what I meant by "you can only import/restart/enable a script when a) WLM is open and b) you are signed in" was that the script can only be MANUALLY started when you are signed in. The script automatically starts when WLM opens if it has already been manually enabled (by import/restart/enable) and continues to run until WLM closes (unless it is disabled). The thing that caught me was that I thought scripts could not be manually started when signed out...

quote:

---

Originally posted by CookieRevised
Why don't you create the window and fill in the listview when it is actually needed for the first time? In that way you don't slow other things down...

Unless you constantly need to add to the listview also... but then again, you also could simply store everything in an array and only create the listview (from that array) when it actually needs to be shown to the user. This will be way faster...not only in loading but in general executing too (as updating a listview takes a lot of processing).

---

quote:

---

Originally posted by SpunkyLoveMuff

quote:

---

Originally posted by CookieRevised
Why don't you create the window and fill in the listview when it is actually needed for the first time? In that way you don't slow other things down...

Unless you constantly need to add to the listview also... but then again, you also could simply store everything in an array and only create the listview (from that array) when it actually needs to be shown to the user. This will be way faster...not only in loading but in general executing too (as updating a listview takes a lot of processing).

---

Basically whats happening is, the array is loaded in the list box and then, when a certain function is called, a loop searches to see if a variable is equal to the current value in the 1st column... if it is, the variable is replaced by the current value in the second column and passed back...

it's basically replacing email addresses with a user defined nickname so that my script can show who the user is talking to, without giving away they're email address...

As the function that performs this is called quite frequently, it's not a very good idea to read from the registry at that point. So it's easier to read the registry at startup and then it updates as it goes along...

---

The list view does serve a purpose and is not just there for my benefit... It allows the user to see the nicknames they've entered as well as remove entries and hopefully, soon I'll be able to put a "modify" button as well.

One thing that does concern me is about a character limit in the registry value... Will I need to eventually just switch to a text file?

quote:

---

Originally posted by SpunkyLoveMuff
The list view does serve a purpose and is not just there for my benefit... It allows the user to see the nicknames they've entered as well as remove entries and hopefully, soon I'll be able to put a "modify" button as well.

---

quote:

---

Originally posted by SpunkyLoveMuff
One thing that does concern me is about a character limit in the registry value... Will I need to eventually just switch to a text file?

---

quote:

---

Originally posted by CookieRevised
quote:

Originally posted by SpunkyLoveMuff
One thing that does concern me is about a character limit in the registry value... Will I need to eventually just switch to a text file?


no worries I'd say... The character limit of a REG_SZ registry value is way bigger than what you'll ever need for a nickname or something though.

---

quote:

---

Originally posted by SpunkyLoveMuff

Well, I'm using one REG_SZ for EVERY email and nickname, which I'm guessing is gonna be a problem at some stage

---