Hi,

This script will notify you when you recieve a new private message on this forum



Known problems:

• [FIXED] Clears your unread posts list

Awesome, I doubt I would use it as I am always logged in and its usually open so.

If it clears you unread posts list, is it possible for it to detect the 'new' PMs instead of 'unread' PMs?

Nagamasa.

P.S I probably wont use the script, but it depends...

quote:

---

Originally posted by Nagamasa
If it clears you unread posts list, is it possible for it to detect the 'new' PMs instead of 'unread' PMs?

Nagamasa.

P.S I probably wont use the script, but it depends...

---

quote:

---

Originally posted by mickael9
I was talking about unread posts (= new posts), not unread PMs

---

"Doesn't appear to be a valid script pack"

Also, there is no need for the enable option in this script

quote:

---

Originally posted by SpunkyLoveMuff
"Doesn't appear to be a valid script pack"

Also, there is no need for the enable option in this script

---

I like it! But I'd recommend you to widen the text labels a bit, so it can fit the translations. (e.g. the word "Activeren" doesn't fit in the check box for Enable)

Very good script!

quote:

---

Originally posted by Mattike
I like it! But I'd recommend you to widen the text labels a bit, so it can fit the translations. (e.g. the word "Activeren" doesn't fit in the check box for Enable)

---

quote:

---

Originally posted by Mattike
Very good script!

---

quote:

---

Originally posted by mickael9
Fixed

---

code:

---

<?xml version="1.0" encoding="utf-16" ?>
<!-- Dutch translation by Mattike -->
<Lang>
  <String Name="NewPM">Je hebt een nieuw persoonlijk bericht!&#x0A;Onderwerp:</String>
  <String Name="ConfigUserName">Gebruiker:</String>
  <String Name="ConfigPassword">Wachtwoord:</String>
  <String Name="ConfigLanguage">Taal:</String>
  <String Name="ConfigCheckEvery">Controleer op nieuwe pm's iedere:</String>
  <String Name="ConfigMinutes">minuten</String>
  <String Name="ConfigEnable">Activeren</String>
  <String Name="ConfigOK">OK</String>
  <String Name="ConfigCancel">Annuleren</String>
</Lang>

---

quote:

---

Originally posted by Mattike

code:

---

  <String Name="ConfigCheckEvery">Controleer op nieuwe pm's iedere:</String>

---

---

code:

---

<?xml version="1.0" encoding="utf-16" ?>
  <String Name="ConfigCheckEvery">Controleer op nieuwe PB's iedere:</String>

---

quote:

---

Originally posted by Mattike

quote:

---

Originally posted by mickael9
Fixed

---

Thanks! Dutch translation works great now:

code:

---

<?xml version="1.0" encoding="utf-16" ?>
<!-- Dutch translation by Mattike -->
<Lang>
  <String Name="NewPM">Je hebt een nieuw persoonlijk bericht!&#x0A;Onderwerp:</String>
  <String Name="ConfigUserName">Gebruiker:</String>
  <String Name="ConfigPassword">Wachtwoord:</String>
  <String Name="ConfigLanguage">Taal:</String>
  <String Name="ConfigCheckEvery">Controleer op nieuwe pm's iedere:</String>
  <String Name="ConfigMinutes">minuten</String>
  <String Name="ConfigEnable">Activeren</String>
  <String Name="ConfigOK">OK</String>
  <String Name="ConfigCancel">Annuleren</String>
</Lang>

---

---

quote:

---

Originally posted by mickael9
How do you say "Settings" in Dutch ? (window title / menu caption) ?

---

quote:

---

Originally posted by foaly

quote:

---

Originally posted by mickael9
How do you say "Settings" in Dutch ? (window title / menu caption) ?

---

Instellingen

---

code:

---

<String Name="Error">Error</String>
<String Name="ConfigErrorSpecifyUserName">Plase specify an user name</String>
<String Name="ConfigErrorSpecifyPassword">Please specify a password</String>
<String Name="ConfigErrorIncorrectCheckInterval">Incorrect check interval</String>

---

quote:

---

Originally posted by SpunkyLoveMuff
"Doesn't appear to be a valid script pack"

Also, there is no need for the enable option in this script

---

quote:

---

Originally posted by Mattike
Thanks! Dutch translation works great now:

code:

---

<String Name="ConfigUserName">Gebruiker:</String>

---

---

quote:

---

Originally posted by foaly

quote:

---

Originally posted by mickael9
How do you say "Settings" in Dutch ? (window title / menu caption) ?

---

Instellingen

---

quote:

---

Originally posted by mickael9
Can you translate this ?

code:

---

<String Name="Error">Error</String>
<String Name="ConfigErrorSpecifyUserName">Plase specify an user name</String>
<String Name="ConfigErrorSpecifyPassword">Please specify a password</String>
<String Name="ConfigErrorIncorrectCheckInterval">Incorrect check interval</String>

---

---

quote:

---

Originally posted by CookieRevised

Geef een gebruikersnaam op:
Geef een wachtwoord op:
Foutief controle-interval

---

code:

---

<String Name="Error">Error</String>

---

quote:

---

Originally posted by CookieRevised

And I dunno what the default check-interval is, but I would make that 5 minutes, certainly not 1 minute !

---

quote:

---

Originally posted by mickael9

code:

---

<String Name="Error">Error</String>

---

?

---

0.4 is out

- The settings window isn't shown immedialtly (labels text & settings are loaded before)
- Added translations for :

• the menu and the settings window titlebar / caption.
  
• The error messages shown when you leave a field blank in the settings window.

quote:

---

Originally posted by CookieRevised
Make that "Gebruikersnaam:"

---

hmmyeah, "login" and "wachtwoord" would be better then...

Mattike, I need you to translate "Check now" in Ducth for the next version.

Isn't it something like "Controle nu"?

In English, things like that (command verbs) are always in the infinitive form. Many people forget this and interpret the English captions wrong when they translate...

"Check Now" is not "controleer nu" (first person), but "nu controleren" (infinitive)....

Though it depends on what "Check Now" stands for. Checking for updates ("controleren op updates")? Checking something cool out ("zie dit" or something like that... sounds dodgy though)? Checking a setting ("nu selecteren")? etc...

When you need something translated, _always_ place it in the correct context since stuff can rarely be translated literally and still be correct in the context. Also the size available is of importance. Aka: requesting something to be translated without these two important things is useless.

quote:

---

Though it depends on what "Check Now" stands for. Checking for updates ("controleren op updates")? Checking something cool out ("zie dit" or something like that... sounds dodgy though)? Checking a setting ("nu selecteren")? etc...

---

quote:

---

Originally posted by mickael9

quote:

---

Though it depends on what "Check Now" stands for. Checking for updates ("controleren op updates")? Checking something cool out ("zie dit" or something like that... sounds dodgy though)? Checking a setting ("nu selecteren")? etc...

---

"Check for new private messages."

---

code:

---

String.prototype.isEmpty = function()
{
    if (this.replace(/^ +/, '').replace(/ +$/, '') == '')
        return true;
   
    return false;
}

---

code:

---

String.prototype.isEmpty = function()
{
    return (this.replace(/^ +| +$/g, '') === '')
}

---

(some scripts do write (default) stuff to the registry, eg: when they can't find a setting, which is )

code:

---

function Logout_Callback()
{
    if (objXmlHttp.readyState == 4)
    {
        Login();
    }
}

---

code:

---

function OnEvent_Initialize(blnMessengerStart)
{
    LoadStrings();
   
    if (SettingsOK())
        StartTimerAndCheck();

    else
        ShowConfigDialog();
}

---

code:

---

function OnEvent_Timer(strTimerId)
{
    if (strTimerId == 'CheckTimer')
    {
        StartTimerAndCheck();
    }
}

---

code:

---

function OnEvent_Timer()
{
    StartTimerAndCheck();
}

---

code:

---

function OnGetScriptMenu(intLocation)
{
    var strMenu = '<ScriptMenu>';
    strMenu    +=     '<MenuEntry Id="mnuSettings">' + Lang.Settings + '</MenuEntry>';
    strMenu    += '</ScriptMenu>';
   
    return strMenu;
}

---

code:

---

function OnGetScriptMenu()
{
    return '<ScriptMenu>'
      +      '<MenuEntry Id="mnuSettings">' + Lang.Settings + '</MenuEntry>'
      +    '</ScriptMenu>';
}

---

quote:

---

btw, can I suggest another way of logging in?

The current method logs people out, even if they don't wanna. Also, all the steps you do aren't needed.

Just go directly to "http://shoutbox.menthix.net/private.php?fid=1" and if a page appears that the user isn't logged in, only then explicitly log in (and back out later). If that page isn't shown, the user is already logged in and you will go directly to the inbox. In the latter case, you should not log out either.

---

quote:

---

Another suggestion: The title of the script is "MsgHelp Private Message Notifier". This is too long to be shown in the script list. Also you use "MsgHelp PM Notifier" as title for the prefs window, which is inconsistant with the script's title. So, to strike two flies at the same time, I would stick to "MsgHelp PM Notifier" for the script title and message boxes, etc too.

---

quote:

---

code:

---

String.prototype.isEmpty = function()
{
    if (this.replace(/^ +/, '').replace(/ +$/, '') == '')
        return true;
   
    return false;
}

---

To trim a string from spaces, you can use this.replace(/^ +| +$/g, '')
Also, you don't need an IF THEN if you directly return true or false according to the check.
thus:

code:

---

String.prototype.isEmpty = function()
{
    return (this.replace(/^ +| +$/g, '') === '')
}

---

(and instead of a space, maybe better use a spacing character which is  \s

---

quote:

---

In the Settings.Set prototype I would suggest to add a third parameter which defines the type of registry key you're going to write. As it is now, you only write strings, but CheckInterval and Enable are better to be written as DWORDs.

---

quote:

---

Instead of using == and != here and there, use === and !==.
See JScript 5.6 documentation or one of my forum posts why.

---

quote:

---

I see you check on no/empty input and then set the focus to that control... All I can say is for this. Most complete and user friendly checking I've seen.

You also don't write settings to the registry when it is not needed (eg: when starting up or when user hasn't changed anything), also (some scripts do write (default) stuff to the registry, eg: when they can't find a setting, which is ).

Example for all

---

quote:

---

Related to the above, check if the CheckInterval isn't greater than
86400000/60/1000 = 1440, since a timer value can't be bigger than 86400000.

Don't forget to change function SettingsOK too.

---

quote:

---

code:

---

function Logout_Callback()
{
    if (objXmlHttp.readyState == 4)
    {
        Login();
    }
}

---

Isn't that going to give an endless loop when there is some fault where the user of the script isn't the user who was logged in??? trying to log in, different user detected, log out, trying to log in, different user detected, log out, trying to log in, etc...

I can understand you first log out and then try to log in with the correct user, but the way it is implemented will also make that you constantly loop when the logging in fails and when again another user is shown.

Either do it differently, or make it only check a certain amount of times and then showing an error.

---

quote:

---

code:

---

function OnEvent_Initialize(blnMessengerStart)
{
    LoadStrings();
   
    if (SettingsOK())
        StartTimerAndCheck();

    else
        ShowConfigDialog();
}

---

Do not use OnEvent_Initialize to load the settings. Use OnEvent_SignIn or even better OnEvent_SigninReady which makes your script user specific (also store your settings user specific!!!), which is very very very mandatory for something like this!!! (And don't forget to cancel the timer when the user signs out of course).

---

quote:

---

code:

---

function OnEvent_Timer(strTimerId)
{
    if (strTimerId == 'CheckTimer')
    {
        StartTimerAndCheck();
    }
}

---

Since you only use one timer, you don't need to check upon the timer id.

And thus:

code:

---

function OnEvent_Timer()
{
    StartTimerAndCheck();
}

---

---

quote:

---

Same goes for the event OnEvent_MenuClicked.

---

quote:

---

code:

---

function OnGetScriptMenu(intLocation)
{
    var strMenu = '<ScriptMenu>';
    strMenu    +=     '<MenuEntry Id="mnuSettings">' + Lang.Settings + '</MenuEntry>';
    strMenu    += '</ScriptMenu>';
   
    return strMenu;
}

---

No need for the variable and parameters:

code:

---

function OnGetScriptMenu()
{
    return '<ScriptMenu>'
      +      '<MenuEntry Id="mnuSettings">' + Lang.Settings + '</MenuEntry>'
      +    '</ScriptMenu>';
}

---

---

quote:

---

if (objFileName.match(/^(.*)\.xml$/i))
=>
if (objFileName.match(/^(.+)\.xml$/i))

---

0.5 is out

quote:

---

Originally posted by mickael9

quote:

---

In the Settings.Set prototype I would suggest to add a third parameter which defines the type of registry key you're going to write. As it is now, you only write strings, but CheckInterval and Enable are better to be written as DWORDs.

---

I think I will detect the type of the variable instead ^^

---

quote:

---

Originally posted by mickael9

quote:

---

Instead of using == and != here and there, use === and !==.
See JScript 5.6 documentation or one of my forum posts why.

---

Hum ... but String.replace returns a string, so I don't need === no ?

---

quote:

---

Originally posted by mickael9

quote:

---

code:

---

function OnEvent_Initialize(blnMessengerStart)
{
    LoadStrings();
   
    if (SettingsOK())
        StartTimerAndCheck();

    else
        ShowConfigDialog();
}

---

Do not use OnEvent_Initialize to load the settings. Use OnEvent_SignIn or even better OnEvent_SigninReady which makes your script user specific (also store your settings user specific!!!), which is very very very mandatory for something like this!!! (And don't forget to cancel the timer when the user signs out of course).

---

I will allow the user to leave the fields blank when the "Enable" checkbox is disabled. Maybe change the label to "Enable for the current account".

---

quote:

---

Originally posted by mickael9

quote:

---

Same goes for the event OnEvent_MenuClicked.

---

In the next version, there is a new menu : "Check now"

---

Hello!

I have a question:

Can I make this script for another forum and can you tell me how?
Do I change the url of all things, beeing in your script and change it with my forum-url?!