hey i'm kinda new to scripting but i knw one thing that should be pretty easy..yet it dont do it right..text replacement
some letters i try to have replaced work the way they should but many many others don't

the replacements go for example

Message = Message.replace(/a/gi,"(other wanted character)");

as the part that would replace a sertain piece of text

some of these work but most of my list just randomises the letter it becomes

i was trying to re-create the al bhed translators of final fantasy 10 into an msn script.. which i thougt i had working until i saw most of my letters were made wrong after i finished writing the script

what i was trying to make was
a b c d e f g h i j k l m n o p q r s t u v w x y z =
y p l t a v k r e z g m s h u b x n c d i j f q o w
as my wa of shortcutting to al bhed from the game

but instead when i test the finished script i'd end up with something rediculous like 3 S's 2 T's a few J's and maybe a Q where it belongs and everything lse is random scatter

can anyone help me out here?

It's because when you replace A with Y for example, when it comes to replace the letter Y it will then replace it again with the letter O. You're replacing letters multiple times...

A > Y > O

Not sure how best to explain it

Edit: see here

What is probably happening is the following:
+Your script searches for any occurences of "a"
+Your script finds "a" and replaces it with "b"
+Your script searches for "b"
+Your script finds "b", including the "b" that originally was an "a", and replaces it with "c".

The better way to replace letters where there is a possibility of the replacement letter being replaced itself (if that makes any sense outside of my head) is to just loop through each letter in the string.

e.g.

code:

---

var teststring = "Hello World";
var testarray = teststring.split(""); //convert string into an array
for(i=0;i<testarray.length;i++){
  //do replacing here, get current character with testarray[i];
}
teststring = testarray.join(""); //convert array back to a string

---

but if that's how it goes then wouldn't the whole thing not do anything at all?
because if A>Y>O happens then it'll continue on to U> everything else going on a loop right?

edit:
so what you're saying is a text format code in the replacement character might work?
if it's not then that idea just randomly popped up and i think it's gonna rescur my script thanks ^^

This is because you will just be doing one replace after the other on the one string. For example if you had the string "ABC" and replaced "A" with "B" and then "B" with "C" you will just end up with "CCC" rather than the "BCC" you were after.

To overcome this you will have to put the changes into a new variable.  This code should help with what you need (using what you have written).

code:

---

var alpha = "abcdefghijklmnopqrstuvwxyz";
var code = "ypltavkrezgmshubxncdijfqow";
var Split = Message.split("");
var eSplit = new Array();
for(i=0;i<Split.length;i++){
    for(j=0;j<alpha.length;j++){
        if(Split[i] == alpha.charAt(j)){
            eSplit[i] = code.charAt(j);
            break;
        }
if(j == alpha.length){
eSplit[i] = Split[i];
}
    }
}
var eMessage = eSplit.join("");
Debug.Trace(eMessage);

---

quote:

---

Originally posted by markee
This is because you will just be doing one replace after the other on the one string. For example if you had the string "ABC" and replaced "A" with "B" and then "B" with "C" you will just end up with "CCC" rather than the "BCC" you were after.

To overcome this you will have to put the changes into a new variable.  This code should help with what you need (using what you have written).

code:

---

var alpha = "abcdefghijklmnopqrstuvwxyz";
var code = "ypltavkrezgmshubxncdijfqow";
var Split = Message.split("");
var eSplit = new Array();
for(i=0;i<Split.length;i++){
    for(j=0;j<alpha.length;j++){
        if(Split[i] == alpha.charAt(j)){
            eSplit[i] = code.charAt(j);
            break;
        }
    }
}
var eMessage = eSplit.join("");
Debug.Trace(eMessage);

---

I hope this extract helps you.

---

thank you
i really appreciate it i'll try it out now

edit: i tried that and it's not replacing anything now is there anything else i'm supposed to add to all this?

quote:

---

Originally posted by Red King
edit: i tried that and it's not replacing anything now is there anything else i'm supposed to add to all this?

---

code:

---

Debug.Trace(eMessage);

---

code:

---

return eMessage;

---

quote:

---

Originally posted by Mattike

quote:

---

Originally posted by Red King
edit: i tried that and it's not replacing anything now is there anything else i'm supposed to add to all this?

---

markee's code outputs the text in the debugging window. If you'd know how to script, you'd probably have seen that...

Anyways, replace

code:

---

Debug.Trace(eMessage);

---

with

code:

---

return eMessage;

---

according that you're working in the OnEvent_ChatWndSendMessage event.

---

I'll fix up my code above for you, I'm sorry for forgetting something like that.  It will just carry down any other characters.

EDIT: All fixed, and I'm sorry for not explaining the eMessage thing.  I just used that so as you still had the original message if you needed it for something.

well it's all fixed up and working fine on my ed
i fized it up with that little edit and added every chracter useable into the replacement list so they all work the same..
this is what the translation area has become instead of just a-z lower case

code:

---

var alpha = " !#~?/.>,<\|@':[{]}`£$%^&*()_+=-0987654321abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ";
var code = " !#~?/.>,<\|@':[{]}`£$%^&*()_+=-0987654321ypltavkrezgmshubxncdijfqowYPLTAVKREZGMSHUBXNCDIJFQOW";

---