Hello..

I tried to make my own command. Like this: /test
It doesn´t matter how I try.. I can´t get this to work..


-------------------------------------------------------------------------

var test1 = 'Hello World!';

function OnGetScriptCommands()
{
    var ScriptCommands = "<ScriptCommands>";
    ScriptCommands    +=     "<Command>";
    ScriptCommands    +=         "<Name>test</Name>";
    ScriptCommands    +=         "<Description>testing</Description>";
    ScriptCommands    +=     "</Command>";
    ScriptCommands    += "</ScriptCommands>";

    return ScriptCommands;
}

function OnEvent_ChatWndSendMessage(ChatWnd, Message)
{

        <<Some kind of switch>>   (don´t know how)

    switch ("some thing") {
        case "/test": return function();
    }
}

function() {
    ChatWnd.SendMessage(test1);
}


-------------------------------------------------------------------------

can someone explane the switch and how to use it..
and the return when you have typed the "/test".. I am not sure if that´s correkt either


//Bewwen

var test1 = 'Hello World!';

function OnGetScriptCommands()
{
var ScriptCommands = "<ScriptCommands>";
ScriptCommands    +=     "<Command>";
ScriptCommands    +=         "<Name>test</Name>";
ScriptCommands    +=         "<Description>testing</Description>";
ScriptCommands    +=     "</Command>";
ScriptCommands    += "</ScriptCommands>";

return ScriptCommands;
}

function OnEvent_ChatWndSendMessage(ChatWnd, Message)
{
        switch (Message) {
                case "/test":
                        function foo();
                break;
        }
}
function foo() {
ChatWnd.SendMessage(test1);
}

code:

---

var test1 = 'Hello World!';

function OnGetScriptCommands()
{
var ScriptCommands = "<ScriptCommands>";
ScriptCommands    +=     "<Command>";
ScriptCommands    +=         "<Name>test</Name>";
ScriptCommands    +=         "<Description>testing</Description>";
ScriptCommands    +=     "</Command>";
ScriptCommands    += "</ScriptCommands>";

return ScriptCommands;
}

function OnEvent_ChatWndSendMessage(ChatWnd, Message)
{
switch (Message) {
case "/test":
foo();
break;
}
}
function foo() {
ChatWnd.SendMessage(test1);
}

---

nope.. same error as before..

It just says that "test" is an unknowned command and that I should use 2 / instead

what´s wrong then?

yes i am getting that error with my new script i have created it happens even if i place the commands inside the ScriptInfo.xml file... is it a bug?

I have no idea.. but it is not very funny

quote:

---

Originally posted by effection
yes i am getting that error with my new script i have created it happens even if i place the commands inside the ScriptInfo.xml file... is it a bug?

---

You have to return an empty string with commands, so it will be...
var test1 = 'Hello World!';

code:

---

function OnGetScriptCommands()
{
var ScriptCommands = "<ScriptCommands>";
ScriptCommands    +=     "<Command>";
ScriptCommands    +=         "<Name>test</Name>";
ScriptCommands    +=         "<Description>testing</Description>";
ScriptCommands    +=     "</Command>";
ScriptCommands    += "</ScriptCommands>";

return ScriptCommands;
}

function OnEvent_ChatWndSendMessage(ChatWnd, Message)
{
switch (Message) {
case "/test":
foo();
return "";
break;
}
}
function foo() {
ChatWnd.SendMessage(test1);
}

---

plus has a wiki? haha ooh well i forgot about returning an null sting thanks

quote:

---

Originally posted by effection
plus has a wiki?

---

quote:

---

Originally posted by markee
You have to return an empty string with commands, so it will be...
var test1 = 'Hello World!';

code:

---

function OnGetScriptCommands()
{
var ScriptCommands = "<ScriptCommands>";
ScriptCommands    +=     "<Command>";
ScriptCommands    +=         "<Name>test</Name>";
ScriptCommands    +=         "<Description>testing</Description>";
ScriptCommands    +=     "</Command>";
ScriptCommands    += "</ScriptCommands>";

return ScriptCommands;
}

function OnEvent_ChatWndSendMessage(ChatWnd, Message)
{
switch (Message) {
case "/test":
foo();
return "";
break;
}
}
function foo() {
ChatWnd.SendMessage(test1);
}

---

---

No but I was lazy and just added the line in.  Realistically I could have at least made Message = "" in the case and return Message at the end or I could have used the likes of Cookie's RegExp for commands or something to make it better, but I thought I would just add to the code to minimise confusion (and it doesn't matter anyway).  If you really want to clean the code up then go ahead but I cba and you'll probably only confuse the new scripter (I do not mean to patronise in any way, I'm sorry if I come across as if I do).

I only mentioned it because they might then think that the break is still nessacerry.

The reason why you got that error is because you try to use a child function of an undefined variable "ChatWnd". A fix would be to send the ChatWnd object as a parameter to your foo function, like so:

code:

---

var test1 = 'Hello World!';

function OnGetScriptCommands()
{
var ScriptCommands = "<ScriptCommands>";
ScriptCommands    +=     "<Command>";
ScriptCommands    +=         "<Name>test</Name>";
ScriptCommands    +=         "<Description>testing</Description>";
ScriptCommands    +=     "</Command>";
ScriptCommands    += "</ScriptCommands>";

return ScriptCommands;
}

function OnEvent_ChatWndSendMessage(ChatWnd, Message)
{
switch (Message) {
case "/test":
foo(ChatWnd);
break;
}
}
function foo(ChatWnd) {
ChatWnd.SendMessage(test1);
}

---

code:

---

...
switch (Message) {
case "/test":
return foo(ChatWnd);
break; //not really necessary, it simply makes it look more common.
}
...
function foo(ChatWnd) {
return test1;
}

---