I have trouble with this before, but for some reason this doesn't seem to clear the whole list, it always seems to leave the last item if there are more than 2-3 items in the list... Any idea why? It looks Ok to me and I've tried looping it more times, but it doesn't work

code:

---

for(var i=0; i<=PlusWnd.LstView_GetCount("ListView");i++){
    PlusWnd.LstView_RemoveItem("ListView", 0);
}

---

Try this instead!

code:

---

//ListView_DeleteAll - Deletes all items
//Parameters: hWnd = control handle
function ListView_DeleteAll(hWnd) {
   var LVM_FIRST = 0x1000;
   var LVM_DELETEALLITEMS = (LVM_FIRST + 9);

   return new Boolean(Interop.Call("user32", "SendMessageW", hWnd, LVM_DELETEALLITEMS, 0, 0));
}

//Example
ListView_DeleteAll(PlusWnd.GetControlHandle("ListView"));

---

Or you could use a while(PlusWnd.LstView_GetCount("ListView")) loop which would probably work as well. But I suppose Mattike's method is better

EDIT: Also your current method is looping 1 more time than is necessary as LstView_GetCount gives you the number of items in the listview, not the highest index - have you checked your Script Debugging Window?

quote:

---

Originally posted by Mattike
Try this instead!

---

quote:

---

Originally posted by Volv
Or you could use a while(PlusWnd.LstView_GetCount("ListView")) loop

---

quote:

---

Originally posted by Volv
EDIT: Also your current method is looping 1 more time than is necessary - have you checked your Script Debugging Window?

---

I believe your original problem is related to the fact that PlusWnd.LstView_GetCount("ListView") is not constant (it decreases each time you remove an item) and as such your 'i' isn't going through all the necessary loops.
It works for 1 item because it loops through '0'.
It works for 2 items because it loops through '0', '1'.
It does not work for 3 items because it loops through '0', '1'.
It does not work for 4 items because it loops through '0', '1', '2'.
etc.

EDIT: I don't see why my while() loops wouldn't work though (I haven't tried it though)

I did manage to do it once before...

@Volv: The loop always removes index 0 so it should always remove the top one in the list... there should ALWAYS be a top item in the list

I think we should have a function to clear LstViews and Combos in the next version

It should be

code:

---

while(PlusWnd.LstView_GetCount("ListView") != 0)

---

quote:

---

Originally posted by markee

code:

---

while(PlusWnd.LstView_GetCount("ListView") != 0)

---

---

quote:

---

Originally posted by markee
It should be

code:

---

while(PlusWnd.LstView_GetCount("ListView") != 0)

---

This will give a boolean expression like the while statement wants

---

code:

---

while(PlusWnd.LstView_GetCount("ListView") > 0)

---

quote:

---

Originally posted by SpunkyLoveMuff
I did try that too... I might give it another go though

---

code:

---

while(PlusWnd.LstView_GetCount("ListView") > 0){
    PlusWnd.LstView_RemoveItem("ListView", 0);
}

---

It doesn't matter if you use > or != in this situation because there is no time when it won't return a number equal to or greater than zero.  This is because the only error is if the plus window does not exist or the control ID doesn't exist.  As far as I can tell wouldn't it be quickest to do !== rather than the other 2?

quote:

---

Originally posted by SpunkyLoveMuff

quote:

---

Originally posted by Mattike
Try this instead!

---

That causes an error and so doesn't work

---

quote:

---

Originally posted by Mattike
Uh? Then why does it work flawlessly here? Can you tell me the error please?

---

yo.

code:

---

PlusWnd.SendControlMessage("controlID", 0x1009 /* LVM_DELETEALLITEMS */, 0, 0);

---

I would lean more towards using Mattike/roflmao456's method of using the LVM_DELETEALLITEMS message.

In my previous experience, doing a loop to remove each item is considerably slower and you can see the list getting cleared one by one.

Using the LVM_DELETEALLITEMS message clears the list altogether, and not only does that look nicer, but it probably uses less memory (considering only 1 line is called compared to the n lines used in a loop).

Just my two cents.

Yes indeed, the LVM_DELETEALLITEMS is the best, most efficient and fastest way you can get: it's the pure Win32 API! (and we all love that thing don't we?)

I suggest you to try fix my code (make use of that Debug::Trace function!) or try roflmao456's code. The reason why my function uses a call to SendMessage instead of using PlusWnd::SendControlMessage is so that I don't have to pass that whole PlusWnd object to the function, but roflmao's code will do just the same thing and may turn out even more interesting if you only want to use the list cleaning one or two times and you don't really need a separate function for it.