Is this a good way check if a contact is in a trusted list?

Or is there a more efficient way to do it?

code:

---

var TrustedEmails = "john@hotmail.com,smith@hotmail.com";

function ConfirmTrusted(ChatWnd){
// pretend i passed the ChatWnd from OnEvent_ChatWndReceiveMessage
    var e = new Enumerator(ChatWnd.Contacts);
    for (; !e.atEnd(); e.moveNext()){
        if (TrustedEmails.indexOf(e.item().Email) != -1){
            return true;
        }
    }
    return false;
}

---

What would the purpose of this trusted list be?

some evil purpose that you shouldn't know about

while i'm on the topic of asking questions, how do i tell between a regular message, and an offline message?

nvm i figured out that you can't. Back to the original topic.

Your code isn't too bad actually, however it can indeed be optimized. It's better to store your trusted emails in an array rather than a comma-separated string. This also allows you to loop over the array instead of the chat contacts.

js code:

---

var TrustedEmails = ["john@hotmail.com", "smith@hotmail.com"];

function ConfirmTrusted(ChatWnd){
    var i = 0, item;
    while(item = TrustedEmails[i++]) {
        if(ChatWnd.Contacts.GetContact(item) !== null) return true;
    }
    return false;
}

---

Interesting..
I thought indexOf uses a hashtable algorithm rather than a brute force search trhough all the elements.

quote:

---

Originally posted by ultimatebuster
Interesting..
I thought indexOf uses a hashtable algorithm rather than a brute force search trhough all the elements.

---

ah, thank you.