Hi,

I'm trying to write a script that when I log on from my cell phone messenger client that my home PC messenger change my Display Picture to a mobile picture, then wait 10 mins of idle and change it again to another DP then wait 2 mins and change it back to my default one.

So far I've writen this but it dosent work at all... What I'm doing wrong ?

I would really appreciate some help as I'm not used in jscripting.

Thank you

Juffle

-----Code-----

var mobileCode = "";

function OnEvent_MyNameChange(NewName) {
    if (Messenger.MyName.lastIndexOf(mobileCode)) {
        MsgPlus.AddTimer(on,5000);
    }
}


function OnEvent_Timer(TimerId) {
    if (TimerId == "on") {
        Messenger.MyDisplayPicture = MsgPlus.ScriptFilesPath + "\\images\\mobile_on.gif";
        MsgPlus.AddTimer(off,600000);
    }
    else if (TimerId == "off") {
        Messenger.MyDisplayPicture = MsgPlus.ScriptFilesPath + "\\images\\mobile_off.gif";
        MsgPlus.AddTimer(default,120000);
    }
    else if (TimerId == default) {
        Messenger.MyDisplayPicture = MsgPlus.ScriptFilesPath + "\\images\\default.gif";
        Messenger.MyName = Messenger.MyName.replace(mobileCode,"");
    }
}


function OnEvent_ChatWndReceiveMessage(ChatWnd, Origin, Message, MessageKind) {
    if (Origin == Messenger.MyName) {
        if (Messenger.MyName.lastIndexOf(mobileCode)) {
            MsgPlus.CancelTimer(off);
            MsgPlus.CancelTimer(default);
            MsgPlus.AddTimer(on,5000);
        }
    }
}

---End Of Code-----

For starters:

on, off and default are strings.
And thus there should be quotes around those strings.

You did it twice good in if (TimeId == "on" ) and if (TimeId == "off" ). But all the other occurances of those strings lack the quotes (and thus are threated as undefined variables)....



Another thing you might want to consider: Timers do not stop running after you've signed out!

This means that if you are signed out for some reason, the timers will still keep on running (until they fire). At which time you might not be signed in once again and thus an error will occur when the timer event tries to set your display picture. Similar stuff will happen when you sign out and someone else  (or you with another identity) signs in after that; the timers might still be running and the other person's display picture will be set instead....

To solve this _extremely common_ mistake, simply cancel all the used timers in a OnEvent_SignOut event.

Thank you for pointing that out, but I've noticed that the "OnEvent_MyNameChange" dosent get triggered when the name change occur from another client changing the name even if the name actualy change. So this make my idea useless.

quote:

---

Originally posted by Juffle
Thank you for pointing that out, but I've noticed that the "OnEvent_MyNameChange" dosent get triggered when the name change occur from another client changing the name even if the name actualy change. So this make my idea useless.

---

quote:

---

Originally posted by Juffle
I've noticed that the "OnEvent_MyNameChange" dosent get triggered when the name change occur from another client changing the name even if the name actualy change

---