Shoutbox

Patchou... I hope you get this

i found this in your  MPPluginHeader.h

code:

---

MPPLUGIN_RETURN_VOID DisplayToast(/*[in]*/  const char* sMessage,
                                  /*[in]*/  const char* sTitle,
                                  /*[in]*/  const char* sProgram,
                                  /*[in]*/  bool bPlaySound)
{
    char sMessageSafe[256]; sMessage[255] = '\0';

---

the "sMessage[255] = '\0'; " is not allowed here as its defined as const. VC++ may not have problem with it, however Borland C++ wont compile because of it.

Its NOT a big deal, it can be easily changed to char* without the const, or a little workaround:

code:

---

MPPLUGIN_RETURN_VOID DisplayToast(/*[in]*/  const char* sMessage,
                                  /*[in]*/  const char* sTitle,
                                  /*[in]*/  const char* sProgram,
                                  /*[in]*/  bool bPlaySound)
{
  char *workaround;
    char sMessageSafe[256];
//  sMessage[255] = '\0';
  workaround = (char*) &sMessage[255];

  *workaround = '\0';

---

just wanted to let you know let me know what you think

VC++ have the same error, it can't compile any plug-in

bha, stupid me... I'll fix it in 2 minutes. Thank you

quote:

---

Originally posted by TheBlasphemer
Wouldn't that cause an access violation!?!

---

so true

quote:

---

use this instead:

code:

---

if (lstrlen(sMessage)>255)
   sMessage[256]=0;

---

---

sMessasge[255]=0;

a bit offtopic:

quote:

---

Originally posted by Patchou
bha, stupid me... I'll fix it in 2 minutes. Thank you

---

oh oh... always patchou says that he forgets about it and never fixes   vague patch...   j/k