Shoutbox

mkay, ty matty

matty,

I think you misunderstood me. I have no intend to rewrite this script i made to a script that's somewhat like WINAPI. I pm-ed you about a function in your registry script:

JScript code:

---

function Registry_SetKeyValue(lKeyLocation, sKey, sKeyName, sKeyValue, lpType) {
    var hKey = Interop.Allocate(4);
    var lRetVal = Interop.Call('advapi32.dll', 'RegOpenKeyExW', lKeyLocation, sKey, 0, KEY_WRITE, hKey);
    if (lRetVal === ERROR_SUCCESS) {
        switch (lpType) {
            case REG_EXPAND_SZ :
            case REG_MULTI_SZ :
            case REG_SZ :
                sKeyValue = String(sKeyValue);
                var buff_size = sKeyValue.length;
                var lBufferSize = Interop.Allocate(4);
                lBufferSize.WriteDWORD(0, (2 * buff_size + 2));
                lRetVal = Interop.Call('advapi32.dll', 'RegSetValueExW', hKey.ReadDWORD(0), sKeyName, 0, lpType, sKeyValue, lBufferSize.ReadDWORD(0));
                break;
            case REG_DWORD :
                var lKeyValue = Interop.Allocate(4);
                lKeyValue.WriteDWORD(0, (sKeyValue & 0xFFFFFFFF));
                lRetVal = Interop.Call('advapi32.dll', 'RegSetValueExW', hKey.ReadDWORD(0), sKeyName, 0, REG_DWORD, lKeyValue, 4);
                break;
            case REG_BINARY :
                sKeyValue = String(sKeyValue);
                var lBufferSize = Interop.Allocate(4);
                lBufferSize.WriteDWORD(0, (2 * sKeyValue.length + 2));
                lRetVal = Interop.Call('advapi32.dll', 'RegSetValueExW', hKey.ReadDWORD(0), sKeyName, 0, REG_BINARY, sKeyValue, lBufferSize.ReadDWORD(0));
                break;
            default : return false;
        }
        Registry_CloseKey(hKey.ReadDWORD(0));
        return lRetVal === ERROR_SUCCESS;
    } else { return false; }
}

---

This line:

JScript code:

---

var lRetVal = Interop.Call('advapi32.dll', 'RegOpenKeyExW', lKeyLocation, sKey, 0, KEY_WRITE, hKey);

---

Always returns false, no matter what I try.

A test case:

JScript code:

---

function OnEvent_Initialize(MessengerStart)
{
  var MPLkey = 'SOFTWARE\\Patchou\\Messenger Plus! Live';
var WLMkey;
var WLMexe;


if(Messenger.Version >= 8.5)
{
    WLMkey = 'SOFTWARE\\Microsoft\\MSNMessenger';
    WLMexe = 'SOFTWARE\\Microsoft\\Windows Live\\Messenger';
}

else
{
    WLMkey = 'SOFTWARE\\Microsoft\\MSNMessenger';
    WLMexe = WLMkey;
}

var resultWLMkey = Registry_SetKeyValue(HKEY_CURRENT_USER, WLMkey + '\\PerPassportSettings', 'DefaultMemberName', email, 'REG_BINARY');

var resultMPLkey = Registry_SetKeyValue(HKEY_CURRENT_USER, MPLkey, 'DefaultUser', email, 'REG_SZ');

Debug.Trace("Registry_SetKeyValue resultWLMkey = " + resultWLMkey);
Debug.Trace("Registry_SetKeyValue resultMPLkey = " + resultMPLkey);
}

---

Can't seem to figure out why.. Hope you can!

I don't know if this would affect it, but...

quote:

---

Originally posted by Yustme

JScript code:

---

function Registry_SetKeyValue(lKeyLocation, sKey, sKeyName, sKeyValue, lpType) {
    var hKey = Interop.Allocate(4);
    var lRetVal = Interop.Call('advapi32.dll', 'RegOpenKeyExW', lKeyLocation, sKey, 0, KEY_WRITE, hKey);
    if (lRetVal === ERROR_SUCCESS) {
        switch (lpType) {
            case REG_EXPAND_SZ :
            case REG_MULTI_SZ :
>>>            case REG_SZ :<<<
                sKeyValue = String(sKeyValue);
                var buff_size = sKeyValue.length;
                var lBufferSize = Interop.Allocate(4);
                lBufferSize.WriteDWORD(0, (2 * buff_size + 2));
                lRetVal = Interop.Call('advapi32.dll', 'RegSetValueExW', hKey.ReadDWORD(0), sKeyName, 0, lpType, sKeyValue, lBufferSize.ReadDWORD(0));
                break;
            case REG_DWORD :
                var lKeyValue = Interop.Allocate(4);
                lKeyValue.WriteDWORD(0, (sKeyValue & 0xFFFFFFFF));
                lRetVal = Interop.Call('advapi32.dll', 'RegSetValueExW', hKey.ReadDWORD(0), sKeyName, 0, REG_DWORD, lKeyValue, 4);
                break;
>>>            case REG_BINARY :<<<
                sKeyValue = String(sKeyValue);
                var lBufferSize = Interop.Allocate(4);
                lBufferSize.WriteDWORD(0, (2 * sKeyValue.length + 2));
                lRetVal = Interop.Call('advapi32.dll', 'RegSetValueExW', hKey.ReadDWORD(0), sKeyName, 0, REG_BINARY, sKeyValue, lBufferSize.ReadDWORD(0));
                break;
            default : return false;
        }
        Registry_CloseKey(hKey.ReadDWORD(0));
        return lRetVal === ERROR_SUCCESS;
    } else { return false; }
}

---

(...)

JScript code:

---

function OnEvent_Initialize(MessengerStart)
{
  var MPLkey = 'SOFTWARE\\Patchou\\Messenger Plus! Live';
var WLMkey;
var WLMexe;


if(Messenger.Version >= 8.5)
{
    WLMkey = 'SOFTWARE\\Microsoft\\MSNMessenger';
    WLMexe = 'SOFTWARE\\Microsoft\\Windows Live\\Messenger';
}

else
{
    WLMkey = 'SOFTWARE\\Microsoft\\MSNMessenger';
    WLMexe = WLMkey;
}

>>>var resultWLMkey = Registry_SetKeyValue(HKEY_CURRENT_USER, WLMkey + '\\PerPassportSettings', 'DefaultMemberName', email, 'REG_BINARY');<<<

>>>var resultMPLkey = Registry_SetKeyValue(HKEY_CURRENT_USER, MPLkey, 'DefaultUser', email, 'REG_SZ');<<<

Debug.Trace("Registry_SetKeyValue resultWLMkey = " + resultWLMkey);
Debug.Trace("Registry_SetKeyValue resultMPLkey = " + resultMPLkey);
}

---

---

The Registry_SetKeyValue() function takes the key type as an enumeration (a variable name), whereas you have defined them as strings.  Try it without the single quotes.

Hi wiz,

No it never gets passed this line anyway:

if (lRetVal === ERROR_SUCCESS)


Edit:

I overlooked the last sentence:

quote:

---

The Registry_SetKeyValue() function takes the key type as an enumeration (a variable name), whereas you have defined them as strings.  Try it without the single quotes.

---

I'll try that, ty!

---

Hi whiz,

It seems that did the trick, thanks!

You're welcome! 

Perhaps this is a dumb question, but I have to ask it:

Are you sure you have defined those constants you use correctly at the top of your script? Such as:

js code:

---

var ERROR_SUCCESS = 0x0;

---

since those are not set by Plus! itself, you need to define them yourself.

He is using the registry script from SS5 which declares the variables.