quote:
Originally posted by WDZ
I really doubt that those changed helped... fewer lines of code doesn't necessarily mean more efficiency. There's also some redundant crap, like assigning variables to themselves. All it did was add more complexity to the code and cause more bugs. Did he even test/check his new code or compare it with the original? I doubt it. Also, some parts of functions.php were changed and others weren't... it's inconsistent.
Yes, we did a comparison and the new functions.php does end up more efficiant on most pages which use the functions from it. The same with the new templates class.
The code was checked against the original one and we had a new copy of the development forums setup where Kasper, Blue and a load of others tested the new file to make sure that the permissions system and alike worked properly