quote:
Originally posted by CookieRevised
Oh no! There comes Cookie again!
quote:
I didn't have had a detailed look at the script, but after an extremely quick glance I saw you use a function called
addslashes(). That function can be done extremely shorter:
code:
//Adds slashes before special characters of regular expressions
function addslashes(str) {
return str.replace(/(\W)/g,'\\$1')
}
Hmm... That would replace any non-word characters. I agree it's lots easier, but is it really necessary to replace a "#" character?
quote:
Another thing (rather important) you want to implement (but it will require recoding major parts): If a tag is not used, the value should be incoorperated with the tags that are used.
This means, for example, when you have:
%d days %h hours %n minutes => 2 days 5 hours 3 minutes
and you leave out the days tag it should become:
%h hours %n minutes => 53 hours 3 minutes
That's indeed lots harder, since you don't know what parts should be kept and what should be left out. I could combine "%d" and "%dw" to "%d" which displays "3 days", but I think I better implement those other suggestions you've posted...
quote:
- Update interval must be 15 seconds (or even higher) or higher
Here comes another increament of the minimum interval!
quote:
- The countdown tag is restricted in size, remove that
The problem is: how? I've looked for solutions in the Windows XML Reference in the Scripts Documentation but there are no properties available which let the typing area of the combobox go further than the width of the control.
quote:
- Wrong wording in "reset my psm when countdown is activated" ? (=> 'activated' must be 'deactivated').
Damn it! Totally right.
quote:
- The nickname checkbox is too close to the psm checkbox. psm checkbox might need more space too for other translations.
No problem, I move them. Thanks.
quote:
- The menu after the countdown tag combobox is good, but seems a bit strange that it pops up. One could expect it to pop down. (dunno if this is intended or if this is Plus!'s doing)
It's Plus!' fault.
I wonder how Patchou made the menu in the debugging window to drop down...
quote:
- Change the wording "countdown tag" to "tag" or "(!CD) tag" (or let it also update to countup when a date in the past is selected)
Hmm... good point, I will keep "tag" then.
quote:
- Make it possible to use \n (new line) and \t (tab) in translation texts.
\n is already supported, I already thought about adding \t but I wonder why it should be used for... if you can give me just one example, I add it.
quote:
- Even if same language is selected and one presses ok or apply, read the file again and apply the new translations (very usefull for translators).
Good idea, thanks!
quote:
- If an error needs to be shown (eg: the interval is too low) do it in a messagebox, not a toast
This is changed in build 130, it was in a toast since I was quite n00bish with the Windows API that day.
quote:
- I would change the order of the context menu to:
1) activate
2) refresh
3) -----------
4) options
5) About
6) --------
7) check for updates
in anyways, putting options before check for updates as options is more important and more used (the check for updates isn't needed in the menu though imho, as it is available in the options screen already)
Very good idea, I surely will change that.
quote:
Also, here is a correction for the Dutch language (some things corrected, other things replaced so it closer matches Plus!'s translation).
And also the English language (also with some stuff fixed as listed above)
Can I hug you now? That's just an awesome fix!
----------
quote:
Originally posted by jmccarroll
When I exit out of MSN and restart it, my language automatically switches to Dutch.
Hmm... I'll look for that. Thanks for reporting.
----------
Prepare for 135 soon!
(I hope before 1 September... school... sigh)
/ 
