What happened to the Messenger Plus! forums on msghelp.net?
Shoutbox » MsgHelp Archive » Messenger Plus! for Live Messenger » Scripting » [REQUEST] Sign on alarm

[REQUEST] Sign on alarm
Author: Message:
CookieRevised
Elite Member
*****

Avatar

Posts: 15517
Reputation: 173
– / Male / Flag
Joined: Jul 2003
Status: Away
RE: [REQUEST] Sign on alarm
some quick pointers (Im in a hurry):

* Script pack didn't imported, contained an error (also make your wml files unicode and add the proper header to scriptinfo.xml)

* Ident your code with tabs, add some lines between functions.

* Dont use Messenger.MyEmail for storing information, use Messenger.MyUserID instead (if you can, never put emails directly in the registry as this forms a possible security/privacy risk)

* There is no need for the variable ringing and assigning it 1 or 0; you can leave all those lines and checks out of it.

* Since you only use 1 timer, no need for checking the TimerId; you can leave that check out

* No need for checking the catch error event (if (e != 0)), it will always be something different than 0, otherwise it wouldn't be an error.

* Functions OnGetScriptMenu(), toggle and OnEvent_ContactSignin all miss an error catching (each time you read/write to the registry you must use error catching).

* You didn't declare the variable enabled as a global variable
       
* Unless you're going to use other menu options, checking on the menu id isn't needed

* Using a normal string to contain the email addresses might result in errors when you use eml.indexOf(TheEmail)>-1. Better make eml an array. You can also iterate thru the array more easly.

* since you use a timer in your script, read the important notes about timers here: CookieRevised's reply to [release] Who's online

* other optimizations exist though

;)

This post was edited on 09-05-2006 at 01:51 AM by CookieRevised.
.-= A 'frrrrrrrituurrr' for Wacky =-.
09-05-2006 01:28 AM
Profile PM Find Quote Report
« Next Oldest Return to Top Next Newest »

Messages In This Thread
[REQUEST] Sign on alarm - by Dabbi on 09-04-2006 at 10:08 AM
RE: [REQUEST] Sign on alarm - by benjyrama on 09-04-2006 at 11:43 AM
RE: [REQUEST] Sign on alarm - by AberNStein on 09-04-2006 at 09:32 PM
RE: [REQUEST] Sign on alarm - by Zeh on 09-04-2006 at 09:46 PM
RE: RE: [REQUEST] Sign on alarm - by Chris4 on 09-04-2006 at 09:50 PM
RE: [REQUEST] Sign on alarm - by Zeh on 09-04-2006 at 09:57 PM
RE: [REQUEST] Sign on alarm - by AberNStein on 09-04-2006 at 10:30 PM
RE: [REQUEST] Sign on alarm - by Zeh on 09-04-2006 at 10:33 PM
RE: [REQUEST] Sign on alarm - by AberNStein on 09-04-2006 at 10:57 PM
RE: [REQUEST] Sign on alarm - by Zeh on 09-04-2006 at 10:59 PM
RE: [REQUEST] Sign on alarm - by AberNStein on 09-04-2006 at 11:04 PM
RE: [REQUEST] Sign on alarm - by Chris4 on 09-04-2006 at 11:48 PM
RE: [REQUEST] Sign on alarm - by Zeh on 09-04-2006 at 11:54 PM
RE: [REQUEST] Sign on alarm - by AberNStein on 09-05-2006 at 12:50 AM
RE: [REQUEST] Sign on alarm - by CookieRevised on 09-05-2006 at 01:28 AM
RE: RE: [REQUEST] Sign on alarm - by AberNStein on 09-05-2006 at 01:48 AM


Threaded Mode | Linear Mode
View a Printable Version
Send this Thread to a Friend
Subscribe | Add to Favorites
Rate This Thread:

Forum Jump:

Forum Rules:
You cannot post new threads
You cannot post replies
You cannot post attachments
You can edit your posts
HTML is Off
myCode is On
Smilies are On
[img] Code is On