Hey Cookie, thanks for your reply
you have indeed got some points here, but i'll respond to them one by one.
quote:
Originally posted by CookieRevised
though some notes:
1) The script has problems when you use polygamy. When a user has two messengers open this can easly be checked upon with:code:
var Email = arrdata[1]; // index 12 should give the same email
if (Email !== Messenger.MyEmail) {
... do your stuff
}
You're right here, but i don't use polygamy so I didn't bother
quote:
2) You assume nick is always in the contactlist. This might not be so in a multi-contact conversation. So additional checking is required there too. Or don't grab the nickname from Messenger.MyContacts.GetContact(Email).Name but grab it from the protocol message directly (decodeURI(arrdata[2])).
If the nick in the toast is not in my list, I don't want to see a toast if they're typing to me (someone else might, but I don't), apart from that I've blocked everyone who's not on my list
In multi contact convo's, I wouldn't want a toast for everyone that's typing in there. I see now that I might get a toast like "undefined is typing a message", but i'd fix that by checking if (nick != undefined), so I only get toasts from users on my list.
Also, wouldn't grabbing emails that are NOT on your contactlist cause trouble with the toasts callback function?
quote:
3) the global array found isn't needed. The found variable can be a local boolean.
You're right, I got confused because I first wanted to merge both arrays into one, but for some reason dropped that plan and did it this way.
quote:
4) Although not so crucial in this script, you should be carefull in using timers like that. The timer will still be running when it was started right before the user signs out (and another one signs in). This makes that your array will be used for other users also and in some scripts (this one too, in a specific situation) this will lead to errors or even manipulation of the contactlist of the wrong user.
I don't see how my script can manipulate anyones contactlist.
But then again, I don't know that much about scripting to know what's wrong with it
I see you used the same (or at least very similar) method, except for the my@email.com: in front of it.
quote:
5) in ScriptInfo.xml: the ocx is a ActiveX DLL, this should be listed in <OleFiles>, not <DotNetFiles>.
lol, I took that right out of
the Xniff thread, this post, worked for me (probably because I had already registered the ocx)
quote:
my version of the script:
/ 
