quote:
Originally posted by CookieRevised
Also the parsing of commands isn't entirly correct. The parsing of tags is also not done like in Plus! 3.
What's wrong with that? It just splits out the command and the parameters, I wouldn't know what else plus does?
quote:
Originally posted by CookieRevised
Plugins were/are user specific, this isn't so in your script, hence handling isn't done properly.
I thought about that one, but because Scripts are not user specific anymore, I decided to make the plugins that way too. I know that the email of the user isn't passed, and the initialize function is not called when a user signs in. That's still on the todo list.
quote:
Originally posted by CookieRevised
^^ these things are done within the plugins themselfs by broadcasting a message.
I know that Plus! does it, so I do not catch the messages at all. I just added it to the list because it works, and people might not know that plus still listens to those messages (I honestly wonder why it does that, because in scripts there is another way to do it...).
quote:
Originally posted by CookieRevised
It also doesn't load any of the plugins I have in Plus! 3.
That the big problem with this release, and that's why I gave it a version number less then 1.0. It is just not done yet so things are missing. Patchou once stated that only 10% of the plugins uses the MessengerAPI, so that would mean that 90% of the plugins should work with my script. I am quite sure that that there are much more scripts that use it.
quote:
Originally posted by CookieRevised
Other than this, the code itself is messy and things aren't always done in the cleanest way (eg: some routines which are very slow and long, which can be made way shorter and faster... the registry APIs which aren't used as one should... etc...)
Which ones? I know that I am using the RegQueryValueExW function although it would not be needed, but I use that because I am enumerating value's there and have an open key, so there's no need to open the key again (what the WScript.Shell object would do). I know my routines are long sometimes, but am not aware of them being slow, and I would know where and what I could improve. Any help is appreciated
quote:
Originally posted by CookieRevised
Sorry to write such a negative post about it 
(which you surely didn't expected)
No problem, negative feedback is MUCH better then positive feedback. I am a perfectionist so I like to get better and better. I think I can state that I am a good programmer, but I just don't have much experience JScript neither with C++ (what the plugin is written in). I think I already did a very good job by actually writing a C++ dll that can load the C++ plugins as well as the COM plugins without causing memory leaks etc (at least, I hope it doesn't
). I also succeeded in UNICODE - ANSI conversion etc
.
In conclusion, I know this script is still buggy (although I thought that it should work, and give no errors with loading the dll
) but I could choose between not submitting this script for the contest at all, or submit this (partially working) version. Obviously, I did the latter. I will continue development, and I hope that the script will work as expected soon! But for now, I still think it can be usefull, because there are also quite a few things that do actually work!
/ –
