Shoutbox

When I have the following script installed, the '/all' commnad doesn't work
anyone know why?
Here is the script:

code:

---

function OnEvent_ChatWndSendMessage(ChatWnd, sMessage) {

    if(sMessage.charAt(0) == "/"){
        return parseCommands(sMessage,ChatWnd);
    }
}
function parseCommands(sMessage,iOriginWnd){

    if (sMessage.charAt(0) == '/'){
        if(sMessage.charAt(1) == '/'){
            return sMessage;
        } else {
            var firstSpace = sMessage.search(' ');
            if(firstSpace == -1){
                var command = sMessage.toLowerCase().substr(1);
                var params = '';
            } else {
                var command = sMessage.toLowerCase().substr(1, firstSpace-1);
                var params = sMessage.substr(firstSpace+1);
            }
            if(params != "") { Debug.Trace("The command \"" + command + "\" with the parameters \"" + params + "\" has been parsed."); }
            else { Debug.Trace("The command \"" + command + "\" has been parsed."); }
            switch(command) {
                case 'colour=red':
                    iOriginWnd.SendMessage("4"+params);
                    sMessage = '';
                    break;
                case 'colour=blue':
                    iOriginWnd.SendMessage("12"+params);
                    sMessage = '';
                    break;
                case 'colour=green':
                    iOriginWnd.SendMessage("50"+params);
                    sMessage = '';
                    break;
                case 'colour=yellow':
                    iOriginWnd.SendMessage("8"+params);
                    sMessage = '';
                    break;
                case 'colour=purple':
                    iOriginWnd.SendMessage("6"+params);
                    sMessage = '';
                    break;
                case 'colour=pink':
                    iOriginWnd.SendMessage("13"+params);
                    sMessage = '';
                    break;
                case 'colour=orange':
                    iOriginWnd.SendMessage("36"+params);
                    sMessage = '';
                    break;
                default:
                case 'colour=lilac':
                    iOriginWnd.SendMessage("21"+params);
                    sMessage = '';
                    break;
            }
        }
    }
    return sMessage;
}
function OnGetScriptCommands()
{
    var commands = '<ScriptCommands>';
        commands+='<Command>';
            commands+='<Name>colour=red</Name>';
            commands+='<Description>'+"Change colour of text to red"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
        commands+='<Command>';
            commands+='<Name>colour=blue</Name>';
            commands+='<Description>'+"Change colour of text to blue"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
        commands+='<Command>';
            commands+='<Name>colour=green</Name>';
            commands+='<Description>'+"Change colour of text to green"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
        commands+='<Command>';
            commands+='<Name>colour=yellow</Name>';
            commands+='<Description>'+"Change colour of text to yellow"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
        commands+='<Command>';
            commands+='<Name>colour=orange</Name>';
            commands+='<Description>'+"Change colour of text to orange"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
        commands+='<Command>';
            commands+='<Name>colour=pink</Name>';
            commands+='<Description>'+"Change colour of text to pink"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
        commands+='<Command>';
            commands+='<Name>colour=purple</Name>';
            commands+='<Description>'+"Change colour of text to purple"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
        commands+='<Command>';
            commands+='<Name>colour=lilac</Name>';
            commands+='<Description>'+"Change colour of text to lilac"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
    commands+='</ScriptCommands>';
    return commands;
}

---

Well i imported the script, tried /all and the command did work...
I put in /all hello and pressed <enter> and the word hello came up in pale blue writing (Not sure whether it is ment to do that or not)
Does any other commands workl/don't work?

well, when i type '/all hello' it comes up in pale blue(lilac) writing but only sends 'hello' to the active convo.

Hmm... weird... the same to me when i tried to test it, but after i remove the script it does it fine...
Is that a script to change the colour of the writing?

yes, you have to type /colour=xxxxx

there are only about 10 colours in it at the moment.
oh, by the way, it only changes the colour for one message

That could be the problem, now i have removed the script, it doesn't only let me use the /all command, but the message i wrote (eg /all hello) now appears in my normal text writing (red)
This is something weird... it shouldn't interfere with other commands..

thats what i thought, but for some trange reason it is, wonder why?

quote:

---

Originally posted by 134jimbodude
               

code:

---

...

default:
                case 'colour=lilac':
                    iOriginWnd.SendMessage("21"+params);
                    sMessage = '';
                    break;

...

---

---

Put default under the final break and it should all be fixed.  Any comand you write should change to the lilac colour otherwise I think.  I thought I changed this for you last time but obviously not, sorry.

thanks markee

so, this would work?
[code]

function OnEvent_ChatWndSendMessage(ChatWnd, sMessage) {

    if(sMessage.charAt(0) == "/"){
        return parseCommands(sMessage,ChatWnd);
    }
}
function parseCommands(sMessage,iOriginWnd){

    if (sMessage.charAt(0) == '/'){
        if(sMessage.charAt(1) == '/'){
            return sMessage;
        } else {
            var firstSpace = sMessage.search(' ');
            if(firstSpace == -1){
                var command = sMessage.toLowerCase().substr(1);
                var params = '';
            } else {
                var command = sMessage.toLowerCase().substr(1, firstSpace-1);
                var params = sMessage.substr(firstSpace+1);
            }
            if(params != "") { Debug.Trace("The command \"" + command + "\" with the parameters \"" + params + "\" has been parsed."); }
            else { Debug.Trace("The command \"" + command + "\" has been parsed."); }
            switch(command) {
                case 'colour=red':
                    iOriginWnd.SendMessage("4"+params);
                    sMessage = '';
                    break;
                case 'colour=blue':
                    iOriginWnd.SendMessage("12"+params);
                    sMessage = '';
                    break;
                case 'colour=green':
                    iOriginWnd.SendMessage("50"+params);
                    sMessage = '';
                    break;
                case 'colour=yellow':
                    iOriginWnd.SendMessage("8"+params);
                    sMessage = '';
                    break;
                case 'colour=purple':
                    iOriginWnd.SendMessage("6"+params);
                    sMessage = '';
                    break;
                case 'colour=pink':
                    iOriginWnd.SendMessage("13"+params);
                    sMessage = '';
                    break;
                case 'colour=orange':
                    iOriginWnd.SendMessage("36"+params);
                    sMessage = '';
                    break;
                case 'colour=lilac':
                    iOriginWnd.SendMessage("21"+params);
                    sMessage = '';
                    break;
default:
            }
        }
    }
    return sMessage;
}
function OnGetScriptCommands()
{
    var commands = '<ScriptCommands>';
        commands+='<Command>';
            commands+='<Name>colour=red</Name>';
            commands+='<Description>'+"Change colour of text to red"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
        commands+='<Command>';
            commands+='<Name>colour=blue</Name>';
            commands+='<Description>'+"Change colour of text to blue"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
        commands+='<Command>';
            commands+='<Name>colour=green</Name>';
            commands+='<Description>'+"Change colour of text to green"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
        commands+='<Command>';
            commands+='<Name>colour=yellow</Name>';
            commands+='<Description>'+"Change colour of text to yellow"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
        commands+='<Command>';
            commands+='<Name>colour=orange</Name>';
            commands+='<Description>'+"Change colour of text to orange"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
        commands+='<Command>';
            commands+='<Name>colour=pink</Name>';
            commands+='<Description>'+"Change colour of text to pink"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
        commands+='<Command>';
            commands+='<Name>colour=purple</Name>';
            commands+='<Description>'+"Change colour of text to purple"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
        commands+='<Command>';
            commands+='<Name>colour=lilac</Name>';
            commands+='<Description>'+"Change colour of text to lilac"+'</Description>';
            commands+='<Parameters>Message</Parameters>';
        commands+='</Command>';
    commands+='</ScriptCommands>';
    return commands;
}

I'm quite sure it should, though for making the code look nice you might want to indent the "default:" line so it is flush with the "case" lines