Shoutbox

quote:

---

Originally posted by deAd
The language changes affect the path to the Custom Sounds

---

ermm.. no it doesn't... if it does then you take a totally wrong approach in getting the directory.

Moreover, the custom sound directory isn't always located in application directory under "documents and settings" directory either, but can be located in a subdirectory of the Messenger Plus! directory under "program files"!...

I didn't took a look at your script, but never ever hard code a path. Second, never ever use the "Special Folders" registry key to get to special folders like "Documents and settings". Never ever use environment variables to get to it. What you should do is using Windows API like SHGetSpecialFolderPath and the likes.

EDIT: after reading your post further I see you indeed hard coded the path. This is the worst method you can do actually (even reading the special folders key in the registry is a better method than that).

quote:

---

Originally posted by CookieRevised

quote:

---

Originally posted by deAd
The language changes affect the path to the Custom Sounds

---

ermm.. no it doesn't... if it does then you take a totally wrong approach in getting the directory.

Moreover, the custom sound directory isn't always located in the "documents and settings" directory either...

I didn't took a look at your script, but never ever hard code a path. Second, never ever use the "Special Folders" registry key to get to special folders like "Documents and settings". Never ever use environment variables to get to it. What you should do is using Windows API like SHGetSpecialFolderPath and the likes.

EDIT: after reading your post further I see you indeed hard code the path. This is the worst method you can do actually (even reading the special folders key in the registry is a better method than that).

---

I did hard code the path, I hadn't thought of using the script in different languages. Also, when would the path to the Custom Sounds change? AFAIK they're always in the same directory.

quote:

---

Originally posted by CookieRevised

quote:

---

Originally posted by deAd
I did hard code the path, I hadn't thought of using the script in different languages. Also, when would the path to the Custom Sounds change? AFAIK they're always in the same directory.

---

it doesn't change after you've installed Plus!... but it is not always the same for everybody when they first install Plus!.

---

What would make the path change during the installation?

thanks, it's working now . Great script I must say

quote:

---

Originally posted by deAd
I did hard code the path, I hadn't thought of using the script in different languages. Also, when would the path to the Custom Sounds change? AFAIK they're always in the same directory.

---

1) It is not always the same (as in a subdir under the application directory) for everybody when they first install Plus!.
2) _every_ directory under Documents and settings (including documents & settings itself) can be renamed and moved by the Windows user.


And even if nothing changed, you must never ever hard code a path.

quote:

---

Originally posted by CookieRevised
1) It is not always the same (as in a subdir under the application directory) for everybody when they first install Plus!.
2) _every_ directory under Documents and settings (including documents & settings itself) can be renamed and moved by the Windows user.


And even if nothing changed, you must never ever hard code a path.

---

I have changed the code to get the path using SHGetFolderPath. It will be changed in the next update . I have not accounted for (1) yet, and imo (2) is pretty unlikely -- wouldn't that screw up Plus! as well?

quote:

---

Originally posted by deAd

quote:

---

Originally posted by CookieRevised
1) It is not always the same (as in a subdir under the application directory) for everybody when they first install Plus!.
2) _every_ directory under Documents and settings (including documents & settings itself) can be renamed and moved by the Windows user.


And even if nothing changed, you must never ever hard code a path.

---

I have changed the code to get the path using SHGetFolderPath. It will be changed in the next update . I have not accounted for (1) yet, and imo (2) is pretty unlikely -- wouldn't that screw up Plus! as well?

---

this still isn't correct....

The proper and only correct way to get to the custom sound dir is using the exact same method as Plus! uses, which is:
1) get the APPDATA path by using the SHGetSpecialFolderLocation (with CSIDL_COMMON_APPDATA) and SHGetPathFromIDList APIs
2) If no path is returned or those functions fail, get Plus!'s installation directory from the registry, and append the subdirectory "Data" to it.
3) Only after doing all that, you can append the directory "Messenger Plus!\Custom Sounds" to the path you get from 1 or 2.

^^ trade secret here?

quote:

---

Originally posted by deAd
wouldn't that screw up Plus! as well?

---

no as Plus! uses proper methods to get paths like "documents and settings", "program files", etc, etc... it uses the SHGetSpecialFolderPath , SHGetSpecialFolderLocation, SHGetPathFromIDList, etc APIs like every program should (and does).

quote:

---

Originally posted by CookieRevised

quote:

---

Originally posted by deAd

quote:

---

Originally posted by CookieRevised
1) It is not always the same (as in a subdir under the application directory) for everybody when they first install Plus!.
2) _every_ directory under Documents and settings (including documents & settings itself) can be renamed and moved by the Windows user.


And even if nothing changed, you must never ever hard code a path.

---

I have changed the code to get the path using SHGetFolderPath. It will be changed in the next update . I have not accounted for (1) yet, and imo (2) is pretty unlikely -- wouldn't that screw up Plus! as well?

---

this still isn't correct....

...

no as Plus! uses proper methods to get paths like "documents and settings", "program files", etc, etc... it uses the SHGetSpecialFolderPath , SHGetSpecialFolderLocation, SHGetPathFromIDList, etc APIs like every program should (and does).

---

SHGetFolderPath supercedes SHGetSpecialFolderPath, and accepts the same CSIDL as SHGetSpecialFolderPath. What's wrong with it? I'll add the other steps too.

Wow, I really like this script. It works well.
Just one question- Is there any way to adjust the volume level of the voice clip?
Thanks!

This script's great! It looks, feels and works great! The sound of my speakers isn't that good, so the sound's quality is a bit less but it's an awesome way to send people who don't use Plus! a custom sound. Maybe Patchou should use voice clips as alternative for the Emotion Sounds?

Both thumbs up!