Shoutbox

Yeah no wait i get it but it should check, in case the language is changed O_O

quote:

---

Originally posted by djdannyp

The initial link isn't broken, you're downloading a cached version.  The only way to get the newer version is to clear your browser cache, that's all you need to do

---

That didn't work for me :/

quote:

---

Originally posted by billyy
in case the language is changed O_O

---

In what sense?

well if my messenger plus is set to english (default) but if i install this and later decide to change it to dutch i must reset the script to make it dutch too O_O

quote:

---

Originally posted by billyy
well if my messenger plus is set to english (default) but if i install this and later decide to change it to dutch i must reset the script to make it dutch too O_O

---

The new language is recognized the next time you restart Messenger!

quote:

---

Originally posted by billyy
Yeah no wait i get it but it should check, in case the language is changed O_O

quote:

---

Originally posted by djdannyp

The initial link isn't broken, you're downloading a cached version.  The only way to get the newer version is to clear your browser cache, that's all you need to do

---

That didn't work for me :/

---

Try Internet Explorer then

quote:

---

Originally posted by djdannyp
Try Internet Explorer then

---

no internet explorer didnt work eitehr ubt i dont see why we are still on that because it has been on MediaFire(WIN) for hours

You got any ad-ons or google stuff installed?

How are you trying to clear your download cache?

When I click that link I get 1.7, so it's obviously something to do with your computer caching an old version, not with that link.

Doesn't this highly depend on the font being used?
Not all fonts support all those symbols.

quote:

---

Originally posted by AngelDevil

quote:

---

Originally posted by billyy

    Heheh good service.. ty

    Maybe for a next update you should make the interface more user friendly by adding TABs.. Like one for setting PSM and Nick...

---

Good idea for version 2.0

---

Or even better... don't...

tip: instead of letting it depend on a specific conversation window, or the PSM, etc... simply send the clicked symbol to the keyboard handler. This ensures that you can insert the symbol in whatever edit box is active, no matter if it is a conversation window, PSM edit box, or heck even notepad... And the user doesn't need to be bothered with confusing tabs or whatever.

This would simplify the script and would increase the usefullness.

Also adding a kind of sticky button (typically a pin button in the upper right corner) to keep the window on top or not would be nice.




------------------------

Tips:

Try to avoid things like this:

code:

---

try {
    status = shell.RegRead(MsgPlus.ScriptRegPath + Messenger.MyUserId + "\\Status");
}
catch (Exception) {
    status = 1;
    shell.RegWrite(MsgPlus.ScriptRegPath + Messenger.MyUserId + "\\Status", status, "REG_DWORD");
}

---

I mean the RegWrite in the error catch{}. This is bad practice and only clutters the registry with unneeded settings.
Meaning, if there is no current setting saved in the registry, you should simply only set the setting variable to the default value but not write to the registry.

Writing to the registry should only be done when the user has actually _changed_ the default setting to something else! Try to avoid writing default settings, there is no need at all.
So those RegWrite lines can be removed in those kind of functions (thus this both goes for status and for lang). You already have programmed the only registry writes you need in OnLangWndEvent_CtrlClicked() and OnEvent_MenuClicked().

PS: for including the Messenger.MyUserID. This is also quite often forgotten.

----

As mentioned by others, you forgot to read and check the language setting upon startup.

But there is more. What if the user has altered the language setting in the registry to something your script does not reconize? In that case it should default to English (for example) too. To fix that, move the else if (lang == "English") to the end of the If-Then-Else structure and change it to a simple else, thus without a comparisson:

code:

---

    else if (lang == "Deutsch") {
        ...
        ...
    {
    else
    {
        text[0] = "List of symbols";
        text[1] = "Enable";
        text[2] = "Disable";
        ...
        ...
    }

---

EDIT: apparently you already fixed the above in v1.7

---

---------

The Dutch translation is full of errors. Almost all strings have an error in them. Corrected:

text[0] = "Symbolen invoegen...";
note: all translations should include the ellipsis here if you used a verb to describe an action. An ellipsis is used when another dialog first needs to be opened to do the final action. And better to make "Symbol" plural, since you can actually add more than one symbol.

text[1] = "Inschakelen";
text[2] = "Uitschakelen";

text[5] = "ingeschakeld.";
text[6] = "uitgeschakeld.";

// text[8] = "Taal";
note: not used anymore

text[9] = "Eenvoudige Wiskunde & Symbolen is nu in het Nederlands.";
note: If you're going to translate the title of the script, then you should be consistant and have a seperate translation for that too. eg: in the toast display the title is hard coded and not translated, in other places it is translated.

//text[10] = "Selecteer taal:";
note: not used anymore? If still or agan being used it should be: "Taal selecteren"

text[12] = "Gebruik de code aan de rechter kant of gebruik de knop om een symbool toe te voegen aan een chat gesprek:";
If you do want to use 'chat' (which isn't consitant with the Dutch translation btw) it is one word: 'chatgesprek', without a space.

text[13] = "Grieks";
note: the previous one ("Griekse symbolen") is way too long for the limited space you have.

text[15] = "Varia";
note: "Varieerend" should be spelled as: "Variërend". But better is simply "Varia".

text[16] = "Wiskundige symbolen";

text[17] = "Eenvoudige Wiskunde & Symbolen 1.7 is een script dat je toelaat om symbolen en wiskundige formules toe te voegen aan msn gesprekken.";
note: also see notes on text[9] en text[12]. Also I recommend not to hard code the version number in this string. Get the version number dynamically from a global variable or something.

text[19] = "Bijdrage: .....";
"Bijdragers" is never ever used, instead you can also use "Medewerkers:", although that is more used in the context of co-authors, less in the context of people who helped you out once.
And in English I would change "Collaborators" to "Contributers:".

text[22] = "Selecteer Eenvoudige Wiskunde & Symbolen in het scriptmenu. In de symbolenlijst staan de ondersteunde symbolen geordend per catogorie.\n\nKlik op een knop om het symbool toe te voegen in een gesprek, of gebruik de symboolcode. Met de codes kun je ook symbolen in je persoonlijk bericht en je schermnaam toevoegen.";
note: again the title issue. And in the original Dutch translation you have a nice example here of how things will screw up when you hard code a title translation in each translation line. In the original Dutch translation, the title here is not consistant with some of the other lines.
I also recommend changing "allowed" in "supported" because a lot more is 'allowed', but only those few symbols are supported by your script.
note: too much reasons to list, but the major thing here is that the dialog is too small to show all that text.


text[23] = "Doneren";
note: In menus, the guideline is to use the infinitive form of verbs

text[24] = "Verzenden naar contact";
note: also see text[23]. And the ellipsis should be removed on all translations since there is no extra dialog.

text[25] = "Hey! Download gratis Eenvoudige Wiskunde & Symbolen voor Messenger Plus! Live. Geen malware of virus: ......";
note: again inconsistancy with the title, even in English. Also, try to use the proper and full name of Plus!.

text[26] = "Meer"
note: "Anders" is realy not a good translation in this context

-

There might still be some smaller translation errors or some translations are maybe a bit too long to fit in the controls though. I didn't checked everything extremely closely atm since I'm very very tired.

---------

I would also reorder the menu a bit though. And get rid of the submenu:
  Insert symbols...
  Enable/Disable
  -
  Make a donation
  Send to contact
  -
  Help
  About