Yesterday I realized my MSN servers app was widely used... So I decided to make a new version, with new features and stuff. But i wanted to do it in c++.

My problem: i get a bug, and I don't understand why

I wrote this piece of code to try to get the number of servers.

code:

---

#include <windows.h>
#include <fstream.h>

int GetEntries(char* buffer, long int size);

int main(int argc, char* argv[])
{
    fstream servers("msnservers.dat",ios::in | ios::binary | ios::ate);
    long int fileSize;
    fileSize = servers.tellg();
    char* fileBuffer;
    fileBuffer = new char[fileSize];
    servers.seekg(0);
    servers.read(fileBuffer,fileSize);
    servers.close();
    int entries=GetEntries(fileBuffer,fileSize);
    MessageBox(0,reinterpret_cast<const char*>(entries),'\0',0);
    delete[] fileBuffer;
    return 0;
}

int GetEntries(char* buffer, long int Size) {
    char tempchar;
    int temp = 0;
    for(int i = 0; i < Size; i++) {
        tempchar=buffer[i];
        MessageBox((HWND)0,reinterpret_cast<const char*>(tempchar),'\0',0);
    }
    return temp;
}

---

quote:

---

Originally posted by Millenium_edition
Yesterday I realized my MSN servers app was widely used... So I decided to make a new version, with new features and stuff. But i wanted to do it in c++.

My problem: i get a bug, and I don't understand why

I wrote this piece of code to try to get the number of servers.

code:

---

#include <windows.h>
#include <fstream.h>

int GetEntries(char* buffer, long int size);

int main(int argc, char* argv[])
{
    fstream servers("msnservers.dat",ios::in | ios::binary | ios::ate);
    long int fileSize;
    fileSize = servers.tellg();
    char* fileBuffer;
    fileBuffer = new char[fileSize];
    servers.seekg(0);
    servers.read(fileBuffer,fileSize);
    servers.close();
    int entries=GetEntries(fileBuffer,fileSize);
    MessageBox(0,reinterpret_cast<const char*>(entries),'\0',0);
    delete[] fileBuffer;
    return 0;
}

int GetEntries(char* buffer, long int Size) {
    char tempchar;
    int temp = 0;
    for(int i = 0; i < Size; i++) {
        tempchar=buffer[i];
        MessageBox((HWND)0,reinterpret_cast<const char*>(tempchar),'\0',0);
    }
    return temp;
}

---

it gives me the ugly XP crash box. (I'm using ms vc++ 6 as a compiler, and I'm happy with it.)

Now, could someone please tell me what's wrong?

---

tried the GNU c++ compiler, didn't work either.



nmv, found the bug. stupid messagebox call. >.<

quote:

---

Originally posted by Millenium_edition

code:

---

        MessageBox((HWND)0,reinterpret_cast<const char*>(tempchar),'\0',0);

---

---

code:

---

char tmp[2];
tmp[0]=tempchar;
tmp[1]='\0';
MessageBox(NULL,tmp,NULL,NULL);

---

quote:

---

Originally posted by raceprouk

quote:

---

Originally posted by Millenium_edition

code:

---

        MessageBox((HWND)0,reinterpret_cast<const char*>(tempchar),'\0',0);

---

---

I'm surprised that compiled, sort of. Passing a char when you need a char* should be picked up by the compiler.

---

quote:

---

Originally posted by TheBlasphemer

quote:

---

Originally posted by raceprouk

quote:

---

Originally posted by Millenium_edition

code:

---

        MessageBox((HWND)0,reinterpret_cast<const char*>(tempchar),'\0',0);

---

---

I'm surprised that compiled, sort of. Passing a char when you need a char* should be picked up by the compiler.

---

not if you tell it explicitly to reinterpret cast

---

quote:

---

Originally posted by TheBlasphemer

quote:

---

Originally posted by raceprouk

quote:

---

Originally posted by Millenium_edition

code:

---

        MessageBox((HWND)0,reinterpret_cast<const char*>(tempchar),'\0',0);

---

---

I'm surprised that compiled, sort of. Passing a char when you need a char* should be picked up by the compiler.

---

not if you tell it explicitly to reinterpret cast

---

being a noob (i am an intermediate-level c++ programmer [or whtevr, i cannot find the correct expression, excuse my poor english ]) i suggest u keep away from reinterpret_cast as fire!!
use static_cast, or dynamic_cast instead