Shoutbox

help (debug this script - syntax error) - Printable Version

-Shoutbox (https://shoutbox.menthix.net)
+-- Forum: MsgHelp Archive (/forumdisplay.php?fid=58)
+--- Forum: Messenger Plus! for Live Messenger (/forumdisplay.php?fid=4)
+---- Forum: Scripting (/forumdisplay.php?fid=39)
+----- Thread: help (debug this script - syntax error) (/showthread.php?tid=70286)

help (debug this script - syntax error) by Wakaki on 01-04-2007 at 02:56 PM

this is my script:

code:
//global variables:   
        var fsObj = new ActiveXObject("Scripting.FileSystemObject");
        var fileObj = fsObj.OpenTextFile(MsgPlus.ScriptFilesPath + '\\defwelcomemsg.txt', 1);
        var DefWelcomemsg = fileObj.ReadAll();
        fileObj.Close();
       
        var fsObj2 = new ActiveXObject("Scripting.FileSystemObject");
        var fileObj2 = fsObj2.OpenTextFile(MsgPlus.ScriptFilesPath + '\\defgoodbyemsg.txt', 1);
        var DefGoodbyemsg = fileObj2.ReadAll();
        fileObj2.Close();
       

//functions
function OnEvent_Initialize(MessengerStart)
{

}

function OnGetScriptMenu(Location)
{
    var ScriptMenu ="<ScriptMenu>";
    ScriptMenu +="<MenuEntry Id=\"window\">Polite Preferences</MenuEntry>";
    ScriptMenu +="</ScriptMenu>";
    return ScriptMenu;
}

function OnEvent_MenuClicked(MenuId, Location, Wnd)
{
    switch(MenuId)
    {
        case "window":
       
        var PlusWnd = MsgPlus.CreateWnd( 'windows_new.xml', 'Polite', 0 );
        PlusWnd.SetControlText("EdtWelcomeMsg", DefWelcomemsg)
        PlusWnd.SetControlText("EdtGoodbyeMsg", DefGoodbyemsg)
       
        break;
    }
       
}



function OverwriteFile (file, content)
{
        var fileObj4 = new ActiveXObject("Scripting.FileSystemObject").OpenTextFile(MsgPlus.ScriptFilesPath + '\\' + file, 2, 0);
        fileObj4.Write(content);
        fileObj4.Close();
}

function OnWindowidEvent_CtrlClicked(PlusWnd, CtrlId) {
if(CtrlId == "BtnSave") {
OverwriteFile("defwelcomemsg.txt", PlusWnd.GetControlText("EdtWelcomeMSg");
OverwriteFile("defgoodbyemsg.txt", PlusWnd.GetControlText("EdtGoodbyeMsg");
}
}


function OnEvent_Signin(Email)
{
     var Message = DefWelcomemsg;
     MsgPlus.DisplayToast("Hello", Message);

}
function OnEvent_Signout(Email)
{
    var Message = DefGoodbyemsg;
     MsgPlus.DisplayToast("Goodbye", Message);
}


function OnEvent_Uninitialize(MessengerExit)
{
}



it doesnt work in the debugging screen it says that in line 53 ')' was expected
line 53 is (almost) the same as line 54
so i think the error is in both

line 53 and 54:
code:
OverwriteFile("defwelcomemsg.txt", PlusWnd.GetControlText("EdtWelcomeMSg");
OverwriteFile("defgoodbyemsg.txt", PlusWnd.GetControlText("EdtGoodbyeMsg");


RE: help by ins4ne on 01-04-2007 at 03:02 PM

quote:
Originally posted by Wakaki
code:
OverwriteFile("defwelcomemsg.txt", PlusWnd.GetControlText("EdtWelcomeMSg");
OverwriteFile("defgoodbyemsg.txt", PlusWnd.GetControlText("EdtGoodbyeMsg");


Make it
code:
OverwriteFile("defwelcomemsg.txt", PlusWnd.GetControlText("EdtWelcomeMSg"));
OverwriteFile("defgoodbyemsg.txt", PlusWnd.GetControlText("EdtGoodbyeMsg"));

I don't know if it's right but it seems logical to me...
RE: help by pollolibredegrasa on 01-04-2007 at 03:03 PM

The debugger tells you exactly what is wrong.

You need to add another bracket :P

code:
OverwriteFile("defwelcomemsg.txt", PlusWnd.GetControlText("EdtWelcomeMSg"));
OverwriteFile("defgoodbyemsg.txt", PlusWnd.GetControlText("EdtGoodbyeMsg"));

RE: help by Wakaki on 01-04-2007 at 03:26 PM

thank you both i will try it out now
but the save button doesn't work:(

if is press on iyt it does nothing


RE: help by Spunky on 01-04-2007 at 04:03 PM

check the instance name is the same in the XML file and the script (eg. BtnSave)

[offtopic]
This is at least the third thread you have made for this script and all the problems seem to be related. Can you please stick to one thread?
[/offtopic]


RE: help by Wakaki on 01-04-2007 at 04:56 PM

alright

but how do you say that when he clicks that button at the ned he must close the window?


RE: help by Spunky on 01-04-2007 at 05:16 PM

quote:
Originally posted by Wakaki
alright

but how do you say that when he clicks that button at the ned he must close the window?

code:
PlusWnd.Close(x);


x can equal any number, it's up to you what it is... it's not important in this case I think
RE: help (debug this script - syntax error) by Wakaki on 01-06-2007 at 10:21 AM

it doesn't work when i press the button nothing happens i checked the button names


RE: help (debug this script - syntax error) by NanaFreak on 01-06-2007 at 10:23 AM

thats because:

code:
function OnWindowidEvent_CtrlClicked(PlusWnd, CtrlId) {
Windowid needs to be the actual window id...


i hope this helps
RE: help (debug this script - syntax error) by Wakaki on 01-06-2007 at 02:40 PM

silly me thanks nanafreak but now i want to make a checkbox and if its on the script works and els it doesn't so how do you make a checkbox in xml?


RE: help (debug this script - syntax error) by Matti on 01-06-2007 at 05:19 PM

Check the Scripting documentation, please!

code:
<Control xsi:type="CheckBoxControl" Id="ChkThing">
<Position Left="10" Top="10" Width="100" Height="15">
<Caption>Thing</Caption>
</Control>
code:
//Top of script
var active = false;
//In BtnSave block
active = PlusWnd.Button_IsChecked("ChkThing");
//In your script block (where it should test if it's active to continue)
if(active) {
//Do it!
} else {
//Don't do it!
}