Shoutbox

Log Viewer window flickers - Printable Version

-Shoutbox (https://shoutbox.menthix.net)
+-- Forum: MsgHelp Archive (/forumdisplay.php?fid=58)
+--- Forum: Messenger Plus! for Live Messenger (/forumdisplay.php?fid=4)
+---- Forum: WLM Plus! Help (/forumdisplay.php?fid=12)
+----- Thread: Log Viewer window flickers (/showthread.php?tid=82918)
Log Viewer window flickers by Click on 04-03-2008 at 10:37 AM

OK, I tried searching the forums for similar but couldn't find anything.

Test case:

  • Plus! -> Open Chat Log
  • Notice that the list of log files flickers [edit]while the tree control is being populated[/edit]
Is this just a case of needing a WM_SETREDRAW(FALSE) / WM_SETREDRAW(TRUE) pair around the code which is populating the tree control, possibly with a IDC_WAIT cursor while it's doing that?
RE: Log Viewer window flickers by RaceProUK on 04-03-2008 at 12:57 PM

I don't get flicker once the list is populated.

RE: Log Viewer window flickers by Eddie on 04-03-2008 at 01:40 PM

I am also unable to reproduce this issue? :S

RE: Log Viewer window flickers by Click on 04-03-2008 at 01:58 PM

Original post edited. My bad for assuming that people on a technical forum would take that as read. ^o)

RE: Log Viewer window flickers by ahmetgns on 04-06-2008 at 09:07 PM

It has always flickered on my computers after version 4.50 of Plus! while loading the folders in that list.

I think that is something about the improvements on Log Viewer which has been done at version 4.50, but I don't care it that much.

RE: Log Viewer window flickers by RaceProUK on 04-07-2008 at 11:43 AM

I really don't think this is a major issue, or even a minor one, but flickering never looks pretty, so it may be worth fixing in the next release.

RE: RE: Log Viewer window flickers by Click on 04-07-2008 at 02:05 PM

quote:
Originally posted by RaceProUK
I really don't think this is a major issue
I'd agree with that.
quote:
Originally posted by RaceProUK
or even a minor one, but flickering never looks pretty, so it may be worth fixing in the next release.
If it's as easy as the change I suggested, it's just another example of MS's poor design with parts of the UI, as a WM_PAINT ought to be the lowest priority message but instead gets forced for every update to the control.

The same happens for list and combo boxes, I believe.

Ah well, if it can be scheduled for the next release I'll be happy, as it's one of those minor irritants which detracts from what is otherwise a first-rate product.
RE: Log Viewer window flickers by RaceProUK on 04-08-2008 at 07:26 PM

quote:
Originally posted by Click
it's just another example of MS's poor design with parts of the UI
I wouldn't necessarily go that far; after all, if you're adding one element, it's a nuisance to force a redraw afterwards.
RE: Log Viewer window flickers by Click on 04-08-2008 at 08:24 PM

There's a difference between invalidating the control and allowing the next WM_PAINT to redraw it when it's convenient, and forcing a repaint unless SETREDRAW has been explicitly turned off.

WM_PAINT is the lowest priority message and gets special handling anyway to stop multiple paint messages being sent in quick succession; this should have been exploited rather than MS taking the lazy approach and repainting it every time something was changed, even if that has no visible effect, as is often the case.