Basically, it's all in the title, but with a twist: I can't (?) use OnWindowidEvent_Destroyed as I need to get the WindowId from a ComboBox containing a list of other windows; this is fine and I can get that easily. What I need to do is somehow get the WindowId from that list and check whether it has been closed based on that WindowId. So, is it possible?

Store the WindowIds in an object and on Destroy delete them and when you need to check if they are open iterate through the object and see if they exist.

Javascript code:

---

var objWindows = {};
 
function OpenWindow(Name, XML, ShowCode){
    if (typeof objWindows[Name] === 'object' && typeof objWindows[Name].Handle === 'number' && Interop.Call('user32', 'IsWindow', objWindows[Name].Handle) {
        Interop.Call('user32', 'SetForegroundWindow', objWindows[Name].Handle);
        return objWindows[Name];
    }
    if (typeof(ShowCode) === 'undefined') ShowCode = 0;
   
    objWindows[Name] = MsgPlus.CreateWnd(XML, Name, ShowCode);
    return objWindows[Name];
}
 
function CheckIfWindowExists ( Name ) {
    for ( objWindow in objWindows ) {
        if ( objWindow === Name ) return true;
    }
    return false;
}
 
function OnWindowIdEvent_Destroyed(pPlusWnd) {
    delete objWindows[pPlusWnd.WindowId];
}

---

Doesn't appear to be working; _debug is undefined and I've never heard of getfuncname anyway. I can easily replace the _win32 calls with the usual Interop.Call, but I've got no idea what the _debug one is for.

Pretty much what I need is a way of getting an OnWindowidEvent_Destroyed without knowing what the WindowId actually is, as it can't be hardcoded into the function name.

It seems that matty copied that code snippet from Screenshot Sender. The line with _debug can simply be removed, and the _win32 can be replaced by Interop.Call.

However the code could still use some optimization. There's no need for a for-loop to check whether the window exists - you can use "[key] in [enumerable]" as an expression as well:

Javascript code:

---

var objWindows = {};
 
function OpenWindow(Name, XML, ShowCode){
    if (typeof(objWindows[Name]) === 'object' && typeof(objWindows[Name].Handle) === 'number'
         && Interop.Call('user32', 'IsWindow', objWindows[Name].Handle)) {
        Interop.Call('user32', 'SetForegroundWindow', objWindows[Name].Handle);
        return false;
    }
    if (typeof(ShowCode) === 'undefined') ShowCode = 0;
 
    objWindows[Name] = MsgPlus.CreateWnd(XML, Name, ShowCode);
    return objWindows[Name];
}
 
function CheckIfWindowExists ( Name ) {
    return ( Name in objWindows && typeof(objWindows[Name]) === 'object');
}
 
function OnWindowIdEvent_Destroyed(pPlusWnd) {
    delete objWindows[pPlusWnd.WindowId];
}

---

quote:

---

Originally posted by ryxdp
Pretty much what I need is a way of calling OnWindowidEvent_Destroyed without knowing what the WindowId actually is, as it can't be hardcoded into the function name.

---

Javascript code:

---

// Store the event handlers here
var objEvents = {
    'WndMain' : {
        'Destroyed' : function(PlusWnd, ExitCode) {
            // Code goes here
        }
    },
    'WndAbout' : {
        'Destroyed' : function(PlusWnd, ExitCode) {
            // More code here
        }
    }
};
 
// Define the "real" event handlers
function OnWndMainEvent_Destroyed(PlusWnd, ExitCode) {
    return objEvents.WndMain.Destroyed(PlusWnd, ExitCode);
}
 
function OnWndAboutEvent_Destroyed(PlusWnd, ExitCode) {
    return objEvents.WndAbout.Destroyed(PlusWnd, ExitCode);
}
 
// Now you can call the event handlers from anywhere using:
var sWindow = PlusWnd.WindowId;
objEvents[sWindow].Destroyed(PlusWnd, 0);
// You can even get the event name itself dynamically!
var sWindow = PlusWnd.WindowId;
var sEvent = ( foo === bar ? "CtrlClicked" : "Destroyed" );
objEvents[sWindow][sEvent](PlusWnd, 0);

---

quote:

---

Originally posted by Matti
Do you want to destroy the window and thus triggering the Destroyed event or do you only want to call the OnWindowIdEvent_Destroyed function without actually destroying the window?

---

JScript code:

---

function On+GetComboText()+Event_Destroyed(oPlusWnd){
//Change some text and stuff here
}

---

Well, the easiest thing would be to create all possible Destroyed events and those can then check whether they have been created by that main window and then do something.

Here's an idea:

Javascript code:

---

// Stores the created window
var oCreatedWnd;
// Array of window IDs in the combo box
var oWndIds = [ "WndOne", "WndTwo", "WndThree" ];
 
// Creates the new window, pass the main window as parameter
function CreateTheWindow(PlusWnd) {
    var nWndId = PlusWnd.Combo_Gombo_GetCurSel("CmbWindow");
    if( nWndId < 0 ) return;
    var sWndId = oWndIds[nWndId];
 
    oCreatedWnd = MsgPlus.CreateWnd("Interfaces.xml", sWndId);
}
 
// Destroyed event for WndOne
function OnWndOneEvent_Destroyed(PlusWnd, ExitCode) {
    if( PlusWnd === oCreatedWnd ) {
        // Change some text and stuff here
    }
}
 
// Repeat for WndTwo, WndThree,...

---

quote:

---

Originally posted by Matti

...or do you only want to call the OnWindowIdEvent_Destroyed function without actually destroying the window?

...I'd suggest you to move the contents of the event function to some other place. Calling a function in the global scope by its function name in JScript can only be done using eval() and as you know, eval is evil and should be avoided as much as possible. Here's a possible solution:

[CODE SNIPPED]

---

JScript code:

---

function OnWndMainEvent_Destroyed(PlusWnd, ExitCode) {
    // some code
}
 
function RandomFunction() {
    // some code
    // Call the OnWndMainEvent_Destroyed() event in code.
    OnWndMainEvent_Destroyed(pPlusWnd, 0)
    // some code
}

---

quote:

---

Originally posted by Matti
Well, the easiest thing would be to create all possible Destroyed events and those can then check whether they have been created by that main window and then do something.

---

quote:

---

Originally posted by CookieRevised
What would solve everything is a OnWnd_Destroyed(PlusWnd, ExitCode) which will trigger when _any_ plus window is destroyed.

---

quote:

---

Originally posted by ryxdp
Anyway, I was thinking about using RegisterMessageNotification, which would hook the WM_CLOSE message into the created window. Would this be plausible in any way?

---

quote:

---

Originally posted by CookieRevised
Same problem, you would need to hard code the Window ID since the format is:

OnWindowidEvent_MessageNotification(
    [object] PlusWnd,
    [number] Message,
    [number] wParam,
    [number] lParam
);

---

Well, there is a way to create a new event handler function in run-time, but it's really nasty coding. I've been experimenting with this some time ago, but it's just plain ugly. Nevertheless, if it can help you or others, here it is:

Javascript code:

---

function CreateTheWindow( PlusWnd ) {
    var sWndId;
    // Code to retrieve the selected window ID goes here
 
    // Assign a new event in the global scope
    // Unfortunately, eval() is needed for this
    eval( "On"+sWndId+"Event_Destroyed = OnCreatedWindowEvent_Destroyed" );
    // Now the registered events have to be reloaded
    // We'll be loading an empty JScript file to trigger the reloading
    MsgPlus.LoadScriptFile("blank.js");
    // Now that everything is set, create the window
    var oWnd = MsgPlus.CreateWnd( "Interfaces.xml", sWndId );
}
 
// We'll make the new event handlers call this function
function OnCreatedWindowEvent_Destroyed( PlusWnd, ExitCode ) {
    // Code goes here
}

---

• In a JScript environment, global variables cannot be assigned by a variable name through normal code. In JavaScript on the contrary, there is the window object which controls all globally defined variables, allowing developers to use window['name'] to define a new global. The same thing goes for many other languages such as PHP, where you can use $$varname to create variables by a variable name. Unfortunately all of this can't be done in Plus! scripting without eval()...
  
• The created global function won't be registered as event handler right away either. In order for Plus! to re-register the global functions, another script file has to be loaded into the script using MsgPlus::LoadScriptFile.

• Event handlers for all script windows (see CookieRevised's reply to [?] Detecting when a Plus! Window is closed).
  
• An OOP approach for event handlers:
  

  Javascript code:

  ---

  // DEMONSTRATION CODE
  // This does not actually work at the time of writing!
  var fEvent = function( PlusWnd, ExitCode ) {
      // Code goes here
  }
  PlusWnd.AddEvent( 'Destroyed', fEvent );

  ---

  This would not only allow new events to be created in run-time, but also add more than one handler to a single event. This would make it so much easier to manage the code: it would make it possible to put all code for one feature in separate script files instead of having to mix all code for the handlers in one event.