Just out of interest, how do you make Plus! show a toast with an error code instead of an error in the Debug window?  I had a quick look at your code but couldn't see it... 

What exactly do you mean? (as in: which error message?)

Like this.


Occurs when opening the settings window for the second time (or fourth, sixth, and so on).

Well, it doesn't happen here Could be that I've got a private version.

Although it definitely means I'll have something to do in the first couple of days of the upcoming vacation.

Fyi, that'll be in 4 to 5 weeks

quote:

---

Originally posted by whiz
Just out of interest, how do you make Plus! show a toast with an error code instead of an error in the Debug window?  I had a quick look at your code but couldn't see it... 

---

I thought about that, but then I'd have to put one into every function...

Can it go across all functions in a file, like this?

Javascript code:

---

try
{
    function Test1()
    {
        // invalid function
        foo.bar();
    }
    function Test2()
    {
        Test1();
    }
}
catch (error)
{
    MsgPlus.DisplayToast("Error!", error.description);
}

---

The sample code you defined there won't trigger an exception since you're not calling the functions inside your try block, you are just defining them. Due to the nature of JScript's treatment of global objects, it won't check for the existence of foo on declaration, since foo could still be assigned later. Therefore, there's no real use in wrapping function declarations in try-catch blocks.

Perhaps the best way to implement custom exception handling for all your functions, is to wrap the code inside all your event handlers such as OnEvent_Initialize or OnChatWndEvent_Created.

Javascript code:

---

// Main event, wrapped in try-catch block
function OnEvent_Initialize() {
    try {
        DoThis();
        DoThat();
    } catch(error) {
        MsgPlus.DisplayToast("Error!", error.description);
    }
}
 
// Script functions calling each other
function DoThis() {
    HelpMeWithThis();
    CallingUnknownFunction(); // try-catch in main event catches this
}
function HelpMeWithThis() { ... }
function DoThat() { ... }

---

quote:

---

Originally posted by Matti
Perhaps the best way to implement custom exception handling for all your functions, is to wrap the code inside all your event handlers such as OnEvent_Initialize or OnChatWndEvent_Created.

<code>

As you can see, despite being wrapped in other functions, the exception will still reach the try-catch block in the event handler. These are the starting points of your call stacks, so any exception occurring inside a function called from the event will bubble up in the call stack until it hits the try-catch block in your event handler code.

---

Javascript code:

---

Debugger.Catch = function(Function, Error)
{
    Debugger.Trace("/////////////////////////////////////////////////////////////////");
    Debugger.Trace("** Error in: " + Function + " **");
    Debugger.Trace("Description: " + Error.description + " (" + Error.code + ")");
    Debugger.Trace("Error time: " + new Date());
    Debugger.Trace("/////////////////////////////////////////////////////////////////");
}

---

Javascript code:

---

function OnEvent_Initialize(MessengerStart)
{
    try
    {
        Debugger.Call("Initialize", {"MessengerStart" : MessengerStart});
        // ...
        foo.bar(); // invalid function
    }
    catch (error)
    {
        Debugger.Catch("Initialize", error); // line 72
    }
}

---

code:

---

From the Plus! Script Debug...
Error: Object doesn't support this property or method (code: -2146827850)
       File: FnInitialization.js. Line: 72.
Function OnEvent_Initialize returned an error. Code: -2147352318

---

Just a stupid question: does the Debugger object support the Trace() method?

Yes.  Here's the full Debugger object:

Spoiler:

Javascript code:

---

var Debugger = {};
 
Debugger.Start = new Date();
Debugger.Data = [];
 
Debugger.Trace = function(Text)
{
    if (Messenger.MyStatus > 1)
    {
        try
        {
            if (Registry.Read("Options\\ChkDebug"))
            {
                Debug.Trace(Text);
                Debugger.Data.push(Text);
            }
        }
        catch (error)
        {
            Debug.Trace(Text);
            Debugger.Data.push(Text);
        }
    }
    else
    {
        Debug.Trace(Text);
        Debugger.Data.push(Text);
    }
}
 
Debugger.Call = function(Function, Parameters)
{
    var Notif = Function.substr(Function.length - 19, Function.length);
    if (Notif !== "MessageNotification" || (Notif === "MessageNotification" && Registry.Read("Options\\ChkDebugNotif")))
    {
        Debugger.Trace("=================================================================");
        Debugger.Trace("** Event called: " + Function + " **");
        Debugger.Trace("Call time: " + new Date());
        Debugger.Trace("-----------------------------------------------------------------");
        var Count = 0;
        for (var Parameter in Parameters)
        {
            Debugger.Trace("|| " + Parameter + ": " + Parameters[Parameter]);
            Count++;
        }
        if (Count === 0)
        {
            Debugger.Trace("(no attached parameters)");
        }
        Debugger.Trace("=================================================================");
    }
}
 
Debugger.Catch = function(Function, Error)
{
    Debugger.Trace("/////////////////////////////////////////////////////////////////");
    Debugger.Trace("** Error in: " + Function + " **");
    Debugger.Trace("Description: " + Error.description + " (" + Error.code + ")");
    Debugger.Trace("Error time: " + new Date());
    Debugger.Trace("/////////////////////////////////////////////////////////////////");
}
 
Debugger.Save = function(Path)
{
    var TextFile = FSO.CreateTextFile(Path, 2);
    TextFile.WriteLine("");
    TextFile.WriteLine("=================================================================");
    TextFile.WriteLine("**************** Interface Writer: Debugging Log ****************");
    TextFile.WriteLine("-----------------------------------------------------------------");
    TextFile.WriteLine("Start time: " + Debugger.Start);
    TextFile.WriteLine("=================================================================");
    TextFile.WriteLine("");
    for (var X in Debugger.Data)
    {
        TextFile.WriteLine(Debugger.Data[X]);
    }
    TextFile.WriteLine("");
    TextFile.WriteLine("=================================================================");
    TextFile.WriteLine("End time: " + new Date());
    TextFile.WriteLine("=================================================================");
    TextFile.Close();
}

---

Javascript code:

---

function OnEvent_Initialize(MessengerStart)
{
    Debugger.Catch = function(Function, Error)
    {
        Debugger.Trace("/////////////////////////////////////////////////////////////////");
        Debugger.Trace("** Error in: " + Function + " **");
        Debugger.Trace("Description: " + Error.description + " (" + Error.number + ")");
        Debugger.Trace("Error time: " + new Date());
        Debugger.Trace("/////////////////////////////////////////////////////////////////");
    }
   
    try
    {
        Debugger.Call("Initialize", {"MessengerStart" : MessengerStart});
        // ...
        foo.bar(); // invalid function
    }
    catch (error)
    {
        Debugger.Catch("Initialize", error);
    }
}
       

---

code:

---

From the Plus! Script Debug...
/////////////////////////////////////////////////////////////////
** Error in: Initialize **
Description: 'foo' is undefined (-2146823279)
Error time: Thu Jun 10 20:05:41 UTC+0100 2010
/////////////////////////////////////////////////////////////////

---

It might also work as expected if you specify the Debugger object as follows:

JScript code:

---

var Debugger = {
    "Start":    new Date,
    "Data":    new Array(),
    [...]
}

---

JScript code:

---

var MyObject = {
    "SomeProperty":    "Hello world!", // used a comma here; if you omit it, a syntax error will be raised on this line
    "SomeMethod":    function(s) {
        Messenger.DisplayToast("",s); //this sign is within the function itself, so it'll work
    } // not used one here
      // if you put a semicolon (;) here, a syntax error will be raised

---

Still returns the same error.  New code:

Spoiler:

Javascript code:

---

var Debugger =
{
    "Start" : new Date(),
    "Data" : [],
    "Trace" : function(Text)
    {
        if (Messenger.MyStatus > 1)
        {
            try
            {
                if (Registry.Read("Options\\ChkDebug"))
                {
                    Debug.Trace(Text);
                    Debugger.Data.push(Text);
                }
            }
            catch (error)
            {
                Debug.Trace(Text);
                Debugger.Data.push(Text);
            }
        }
        else
        {
            Debug.Trace(Text);
            Debugger.Data.push(Text);
        }
    },
    "Call" : function(Function, Parameters)
    {
        var Notif = Function.substr(Function.length - 19, Function.length);
        if (Notif !== "MessageNotification" || (Notif === "MessageNotification" && Registry.Read("Options\\ChkDebugNotif")))
        {
            Debugger.Trace("=================================================================");
            Debugger.Trace("** Event called: " + Function + " **");
            Debugger.Trace("Call time: " + new Date());
            Debugger.Trace("-----------------------------------------------------------------");
            var Count = 0;
            for (var Parameter in Parameters)
            {
                Debugger.Trace("|| " + Parameter + ": " + Parameters[Parameter]);
                Count++;
            }
            if (Count === 0)
            {
                Debugger.Trace("(no attached parameters)");
            }
            Debugger.Trace("=================================================================");
        }
    },
    "Catch" : function(Function, Error)
    {
        Debugger.Trace("/////////////////////////////////////////////////////////////////");
        Debugger.Trace("** Error in: " + Function + " **");
        Debugger.Trace("Description: " + Error.description + " (" + Error.number + ")");
        Debugger.Trace("Error time: " + new Date());
        Debugger.Trace("/////////////////////////////////////////////////////////////////");
    },
    "Save" : function(Path)
    {
        var TextFile = FSO.CreateTextFile(Path, 2);
        TextFile.WriteLine("");
        TextFile.WriteLine("=================================================================");
        TextFile.WriteLine("**************** Interface Writer: Debugging Log ****************");
        TextFile.WriteLine("-----------------------------------------------------------------");
        TextFile.WriteLine("Start time: " + Debugger.Start);
        TextFile.WriteLine("=================================================================");
        TextFile.WriteLine("");
        for (var X in Debugger.Data)
        {
            TextFile.WriteLine(Debugger.Data[X]);
        }
        TextFile.WriteLine("");
        TextFile.WriteLine("=================================================================");
        TextFile.WriteLine("End time: " + new Date());
        TextFile.WriteLine("=================================================================");
        TextFile.Close();
    }
}

---

It might help if you could point us where line 72 is (or whatever line it was).

Here's something I noticed: you're using the name Function as parameter name, which may conflict with the JScript's built-in Function class. I suggest you change the name of the parameter (and its references).

Also, where are you defining FSO?

Javascript code:

---

    "Save" : function(Path)
    {
        var TextFile = FSO.CreateTextFile(Path, 2);

---

Line 72 is the call to Debugger::Catch.

Javascript code:

---

Debugger.Catch("Initialize", error);

---

Javascript code:

---

var FSO = new ActiveXObject("Scripting.FileSystemObject");

---

Omg you just gave me a great idea



(click to enlarge)

Yeah, the evaluator can be useful for testing code snippets.  Maybe I'll put a file reader in as well... 

Well, I was actually talking about the other window

About the eval window: just be extremely careful with this, as any code can be evaluated during runtime, and if WLM crashes, you might not be able to figure out what's wrong.

Fair enough.