Shoutbox

I am a beginning scripter... I have had limited experience in BASIC, VB, C#. I am just trying to learn the jscript language...

Does anyone know whats wrong with this script?

code:

---

function OnEvent_ChatWndSendMessage(Wnd,Msg) {
    if(Msg == "!picknum") {
return "Pick a number between 1 and 100";
var rndnumber = Math.random() * 100;
}

function OnEvent_ChatWndReceiveMessage(Wnd,Msg,1) {
if(Msg == rndnumber) {
return rndnumber + "was the correct number."
}

---

Thanks

Your OnEvent_ChatWndReceiveMessage has incorrect parameters.

The first parameter is Chat window, yes, but the second is the name of the users sending the message, while the third one being the message itself. Finally, MessageKind is a variable and you can't not set 1 for that

So your codes should look like:

code:

---

function OnEvent_ChatWndReceiveMessage(Wnd,Sender,Msg,MsgKind){
    if(Msg == rndnumber) {
    return rndnumber + "was the correct number."
}

---

quote:

---

Originally posted by Hengy
if(Msg == "!picknum") {
return "Pick a number between 1 and 100";
var rndnumber = Math.random() * 100;
}

---

You should not use return there.

Keyword "return" exits from the current function and returns a value from that function (form here)

And you have extra curly brackets, too

so i've got this now, but it still doen't work...
(please be patient with me...)

code:

---

function OnEvent_ChatWndSendMessage(Wnd,Msg) {
    if(Msg == "!picknum") {
    return Begin();
}

function Begin() {
    var rndnumber = Math.random() * 100;
    return "Pick a number between 1 and 100.";
}

function OnEvent_ChatWndReceiveMessage(Wnd,Sender,Msg,MsgKind){
if(Msg == rndnumber) {
    return rndnumber + "was the correct number.";
}

---

I am afriad I don't see the extra brackets...

quote:

---

Originally posted by Hengy
I am afriad I don't see the extra brackets...

---

What about the ones after each if statement?

Edit: I'm sorry if I sound harsh, but that's truly not my intention

Go easy! Im a beginner...
and it still doesn't work...

It's easier to see bracket mismatches if you put each bracket on a line by itself and indent your code.

code:

---

function OnEvent_ChatWndReceiveMessage(Wnd,Sender,Msg,MsgKind)
{
  if(Msg == rndnumber)
  {
    return rndnumber + "was the correct number.";
  }

---

as you can see there's a missing bracket for the function header.

so it should be like this:

code:

---

function OnEvent_ChatWndReceiveMessage(Wnd,Sender,Msg,MsgKind)
{
  if(Msg == rndnumber)
  {
    return rndnumber + "was the correct number.";
  }
}

---

Edit: actually it's the exact same thing with the first section of your code too:

code:

---

function OnEvent_ChatWndSendMessage(Wnd,Msg) {
if(Msg == "!picknum") {
return Begin();
}

---

there should be one more bracket in the end again.

Thanks! It works!

No problem, glad it works now.

Sorry to bother u all again... but in this thing of code, when I say "!an", it come back "undefined"...

code:

---

function OnEvent_ChatWndSendMessage(Wnd,Msg)
{
if(Msg == "!pick")
    {
    var rndnumber = Math.floor(Math.random()*5);
    return "Pick a number between 0 and 4";
    }
if(Msg == "!an")
    {
    return rndnumber + "was the correct number.";
    }
}

---

Thanks