What happened to the Messenger Plus! forums on msghelp.net?
Shoutbox » MsgHelp Archive » Messenger Plus! for Live Messenger » WLM Plus! Bug Reports » Icon panel

Icon panel
Author: Message:
tony
Senior Member
****

Avatar

Posts: 976
Reputation: 54
36 / Male / Flag
Joined: Jul 2004
O.P. Icon panel
well, this might be a bug, or it might be reported earlier. you guys can delete this asap.

[Image: idkdu2.jpg]

icon panel isnt apearing on the 2th line or the 3th.
[Image: beginnerbadgeef2.gif][Image: danceichigoow9.gif]
09-03-2006 02:03 PM
Profile PM Web Find Quote Report
CookieRevised
Elite Member
*****

Avatar

Posts: 15517
Reputation: 173
– / Male / Flag
Joined: Jul 2003
Status: Away
RE: Icon panel
confirmed

PS: the panel doesn't appear as soon as you have a cariage return; if the first line is simply wrapped on the second line, the panel does appear.

EDIT:
quote:
Originally posted by Mattike
Also confirmed here, very strange bug. :^)
indeed... I wonder too how this was programmed in Plus!, as I would expect it to catch a keypress (much like the ChatWndEditKeyDown event). Failing after a carriage return seems strange.

EDIT (after Patchou's reply): makes all sense now. thanks for explanation Patchou (Y) (and fixing of course)

This post was edited on 09-05-2006 at 05:07 PM by CookieRevised.
.-= A 'frrrrrrrituurrr' for Wacky =-.
09-03-2006 02:06 PM
Profile PM Find Quote Report
Matti
Elite Member
*****

Avatar
Script Developer and Helper

Posts: 1646
Reputation: 39
32 / Male / Flag
Joined: Apr 2004
RE: Icon panel
Also confirmed here, very strange bug. :^)
Plus! Script Developer | Plus! Beta Tester | Creator of Countdown Live | Co-developer of Screenshot Sender 5

Found my post useful? Rate me!
09-03-2006 02:46 PM
Profile E-Mail PM Web Find Quote Report
absorbation
Elite Member
*****

Avatar

Posts: 3636
Reputation: 81
– / Male / Flag
Joined: Feb 2005
RE: Icon panel
Confirmed, after tony pointed it out to me on Messenger :P
09-03-2006 02:51 PM
Profile PM Find Quote Report
Patchou
Messenger Plus! Creator
*****

Avatar

Posts: 8607
Reputation: 201
43 / Male / Flag
Joined: Apr 2002
RE: Icon panel
Fixed, and as you seem interested to know why this was happening, here was the reason: when you press the parenthesis key, a timer is created to display the emoticon panel. When this timer elapses, Messenger Plus! does several checks to make sure the panel should be displayed, for example, it checks if the last character before the selection carret is indeed a parenthesis (in case the user would have continued to typed).

To check this character, the software was getting the text with a call to WM_GETTEXT, then the selection with EM_GETSEL and checked the character at the given index. The problem is that WM_GETTEXT can convert single carriage returns into double ones (\r\n) but as far as the selection is concerned, it still counts for only one character which makes it be off of 1 character and the posiution of the parenthesis couldn't be confirmed.
[Image: signature2.gif]
09-05-2006 04:36 PM
Profile PM Web Find Quote Report
Matti
Elite Member
*****

Avatar
Script Developer and Helper

Posts: 1646
Reputation: 39
32 / Male / Flag
Joined: Apr 2004
RE: Icon panel
Indeed, I now see. When I type a single '(' on a second line, it doesn't show up, but when I type it again, it shows up since the previous character is a '('. :o
Maybe you should replace those double returns with single ones? And then add the amount of found returns before the selection to get the last character? ^o) I don't know, I'm just guessing. :P
Plus! Script Developer | Plus! Beta Tester | Creator of Countdown Live | Co-developer of Screenshot Sender 5

Found my post useful? Rate me!
09-05-2006 05:00 PM
Profile E-Mail PM Web Find Quote Report
Patchou
Messenger Plus! Creator
*****

Avatar

Posts: 8607
Reputation: 201
43 / Male / Flag
Joined: Apr 2002
RE: Icon panel
that would be an idea but this was actually fixed more easily with EM_GETTEXTRANGE as this makes sure there's a 1-1 correspondance between selection index and character index.
[Image: signature2.gif]
09-05-2006 06:19 PM
Profile PM Web Find Quote Report
« Next Oldest Return to Top Next Newest »


Threaded Mode | Linear Mode
View a Printable Version
Send this Thread to a Friend
Subscribe | Add to Favorites
Rate This Thread:

Forum Jump:

Forum Rules:
You cannot post new threads
You cannot post replies
You cannot post attachments
You can edit your posts
HTML is Off
myCode is On
Smilies are On
[img] Code is On