What happened to the Messenger Plus! forums on msghelp.net?
Shoutbox » MsgHelp Archive » Messenger Plus! for Live Messenger » Scripting » [release] My MsgPlus!Live Script

[release] My MsgPlus!Live Script
Author: Message:
CookieRevised
Elite Member
*****

Avatar

Posts: 15519
Reputation: 173
– / Male / Flag
Joined: Jul 2003
Status: Away
RE: [release] My MsgPlus!Live Script
looks good for your first script... Though you have some things you might want to correct:

code:
case 'MnuTest' :
        wnd.SendMessage('{ test goes here }');return;
        return;
You have 1 "return;" too many here... delete the one after the sendmessage line.

code:
case 'MnuInfo' :
(...)
What is shown here can also be shown with the (!VER) tag. Same with the part which handles the "#info" command.

code:
case 'MnuBath' :
        (...)
        if (IAm == "bath") {
                var ValRegPathIAm = MsgPlus.ScriptRegPath + "IAm";
                (...)
        }
        else
        {
                (...)
                var ValRegPathIAm = MsgPlus.ScriptRegPath + "IAm";
                (...)
        }
You already have "var ValRegPathIAm" defined before the if then else statement, no need to do it again in the "if" and again in the "else". Those lines can be deleted.

The same goes for "case 'MnuBath'" , "case 'MnuSleeping'", "case 'MnuEating'". And same goes for the parts of the equivalent commands.

--

And in general: you can make that script really extremely shorter.
(ps: and with this I don't mean the things I've said above. This is an additional thing you can do to the stuff listed above)

--

;)





EDIT:
quote:
Originally posted by JonnyT
(...) and hoefully add custom commands for the #inbath, #sleep etc
before you do that, find the ways to make your script shorter. It would be far more easier to add stuff to the shorter version than to the existing version.

This post was edited on 06-27-2006 at 10:12 PM by CookieRevised.
.-= A 'frrrrrrrituurrr' for Wacky =-.
06-27-2006 10:09 PM
Profile PM Find Quote Report
« Next Oldest Return to Top Next Newest »

Messages In This Thread
[release] My MsgPlus!Live Script - by JonnyT on 06-27-2006 at 09:30 PM
RE: [release] My MsgPlus!Live Script - by Chris4 on 06-27-2006 at 09:57 PM
RE: [release] My MsgPlus!Live Script - by JonnyT on 06-27-2006 at 09:59 PM
RE: [release] My MsgPlus!Live Script - by CookieRevised on 06-27-2006 at 10:09 PM
RE: [release] My MsgPlus!Live Script - by JonnyT on 06-27-2006 at 10:14 PM
RE: RE: [release] My MsgPlus!Live Script - by alexp2_ad on 06-28-2006 at 12:26 AM
RE: [release] My MsgPlus!Live Script - by deAd on 06-27-2006 at 10:29 PM
RE: [release] My MsgPlus!Live Script - by Lou on 06-28-2006 at 12:20 AM
RE: [release] My MsgPlus!Live Script - by CookieRevised on 06-28-2006 at 12:50 AM
RE: [release] My MsgPlus!Live Script - by JonnyT on 06-29-2006 at 04:28 PM
RE: [release] My MsgPlus!Live Script - by Reload2 on 06-29-2006 at 04:29 PM
RE: [release] My MsgPlus!Live Script - by JonnyT on 06-29-2006 at 04:39 PM
RE: [release] My MsgPlus!Live Script - by JonnyT on 06-29-2006 at 11:56 PM


Threaded Mode | Linear Mode
View a Printable Version
Send this Thread to a Friend
Subscribe | Add to Favorites
Rate This Thread:

Forum Jump:

Forum Rules:
You cannot post new threads
You cannot post replies
You cannot post attachments
You can edit your posts
HTML is Off
myCode is On
Smilies are On
[img] Code is On