What happened to the Messenger Plus! forums on msghelp.net?
Shoutbox » MsgHelp Archive » Messenger Plus! for Live Messenger » Scripting » [Betaish-Release] Recall Prefix

[Betaish-Release] Recall Prefix
Author: Message:
CookieRevised
Elite Member
*****

Avatar

Posts: 15519
Reputation: 173
– / Male / Flag
Joined: Jul 2003
Status: Away
RE: [Betaish-Release] Recall Prefix
Nice idea and thingie :P (y)...


some things though:

* function ShowConfigWindow(){
check if config window isn't already showing
(too bad it doesn't make me that tea I wanted at the moment)

* function OnGetScriptMenu(){
Config opens a new window, so add "..."

* function OnEvent_MenuClicked(MenuItemId){
- no need for checking on the menuid when you use only 1 item
- you're missing a closing } in that function

* function SaveSettings(){
put everything in a error handling routine because Messenger.MyEmail will not always be defined (eg: user is logged out while config window is still showing).

* var OnEvent_Initialize = Startup;
Initialize (and thus Startup()) can/will be called before Messenger.MyEmail is defined. Thus use if(Messenger.MyStatus > 1).

* function Startup(){
It is possible that that registry key doesn't exist, so again error checking (default DWORD value is 1). But better yet:

* Check on EnablePreviousRecall each time, since this can be changed while user is logged in. To avoid reading regisrty each time a key is pressed, maybe read it only when a chat window is created. Do if(RecallEnabled == 1) instead of using '===' because, maybe, there is a change someone screwed up and saved the key as a string.

* When user uses other keys than alfanumerical, etc (eg: copy/paste and stuff), the script isn't in 'Waiting' state anymore and thus quote isn't send as a quote. But that's hard to fix properly and 100% and it is something minor anyways.

* When user uses mouse to paste some text after a quote has been send for exalmple, the new text will also be send as a quote. Add Waiting=false in OnEvent_ChatWndSendMessage().

* When another user signs in to Messenger, the default prefix/suffix values are not loaded. aka: don't define default values in global scope of the script but in the LoadSettings function.

* Make Waiting variable chat-specific so that when you select a quote and temporarly chat in another window, you can still send the quote as a quote in the first one.



* love the comments :p



PS: for those who want to know, in Messenger Plus! 3 the registry key to add/change a prefix or suffix:  HKCU\Software\Patchou\MsgPlus2\your@email.com\Preferences\QuoteFormat
see Help: Registry Tweaks

This post was edited on 12-27-2006 at 04:37 AM by CookieRevised.
.-= A 'frrrrrrrituurrr' for Wacky =-.
12-27-2006 03:14 AM
Profile PM Find Quote Report
« Next Oldest Return to Top Next Newest »

Messages In This Thread
[Betaish-Release] Recall Prefix - by Eljay on 12-26-2006 at 09:09 PM
RE: [Betaish-Release] Recall Prefix - by deAd on 12-26-2006 at 09:53 PM
RE: [Betaish-Release] Recall Prefix - by CookieRevised on 12-27-2006 at 03:14 AM
RE: [Betaish-Release] Recall Prefix - by NanaFreak on 12-27-2006 at 05:13 AM
RE: [Betaish-Release] Recall Prefix - by CookieRevised on 12-27-2006 at 05:19 AM
RE: [Betaish-Release] Recall Prefix - by Matti on 12-27-2006 at 09:40 AM
RE: [Betaish-Release] Recall Prefix - by Eljay on 12-27-2006 at 11:53 AM
RE: [Betaish-Release] Recall Prefix - by linx05 on 12-27-2006 at 01:06 PM


Threaded Mode | Linear Mode
View a Printable Version
Send this Thread to a Friend
Subscribe | Add to Favorites
Rate This Thread:

Forum Jump:

Forum Rules:
You cannot post new threads
You cannot post replies
You cannot post attachments
You can edit your posts
HTML is Off
myCode is On
Smilies are On
[img] Code is On