Shoutbox

It's not a quick quote bug, it's either a browser bug or the result of you selecting something by mistake. The quick quote feature simply asks the browser for the "range of text selected by the user." That should be blank if you haven't selected anything. O_o

quote:

---

Originally posted by vax
it's buggy in sense that it will quote text you've selected but clicked away from

---

True, but that's kind of a limitation... I think the feature would stop working properly in certain browsers if I changed it. =p

quote:

---

Originally posted by WDZ
It's not a quick quote bug, it's either a browser bug or the result of you selecting something by mistake. The quick quote feature simply asks the browser for the "range of text selected by the user." That should be blank if you haven't selected anything. O_o

quote:

---

Originally posted by vax
it's buggy in sense that it will quote text you've selected but clicked away from

---

True, but that's kind of a limitation... I think the feature would stop working properly in certain browsers if I changed it. =p

---

I could see if i could improve it a little

quote:

---

Originally posted by -dt-

quote:

---

Originally posted by WDZ
It's not a quick quote bug, it's either a browser bug or the result of you selecting something by mistake. The quick quote feature simply asks the browser for the "range of text selected by the user." That should be blank if you haven't selected anything. O_o

quote:

---

Originally posted by vax
it's buggy in sense that it will quote text you've selected but clicked away from

---

True, but that's kind of a limitation... I think the feature would stop working properly in certain browsers if I changed it. =p

---

I could see if i could improve it a little

---

do it!

heres the new improved code

tested in IE and firefox

this new one should fix the crazy selection issues (blame the function quickquotesel1 for that : <) and if you're using a browser that supports selectionStart and selectionEnd then it should preserve the caret position

GM version:
http://version.thedt.net/scripts/GM/quickquotetester.user.js

code:

---

function quickquote(pid){

    var sel = getCurrentSelection();
    var messageElement = document.getElementsByName('message')[0];
    if(!sel || sel == ""){
        var postdata = document.getElementsByName('qq' + pid)[0].value;
        var username = document.getElementsByName('qqu' + pid)[0].value;
        insertAtCurrentSelection("[quote=" + username + "]" + postdata + "[/quote]\r\n", messageElement);
    }else{
        insertAtCurrentSelection("[quote]" + sel + "[/quote]\n", messageElement);
    }
}


//inserts at the current selection and moves carret
function insertAtCurrentSelection(text, element){
    if(element.selectionStart !== undefined && element.selectionEnd !== undefined){
        var value = element.value;
        var startString = value.substring(0, element.selectionStart);
        var endString = value.substring(element.selectionEnd, value.length);
        var newSelPos = element.selectionEnd + text.length;
        element.value = startString + text + endString;
        element.focus();
        element.setSelectionRange(newSelPos, newSelPos);
    }else{
        //IE doesnt have per input selection, only document.selection, so we cannot insert at the correct position :(
        element.value += text;
        element.focus();
    }



}

function getCurrentSelection(){
    //good browsers
    if(window.getSelection){
        return window.getSelection().toString();
    //IE
    }else if(document.selection && document.selection.type == 'Text' && document.selection.createRange){
        return document.selection.createRange().text;
    }else{
        return false;
    }
}

---

Looks nice, but IIRC the old code "cached" the selected text for a reason: in some browsers (not sure which ), clicking the button will actually unselect the text before quickquote() has a chance to grab it.

I read that using onmousedown instead of onclick for the button will solve that problem though... :\

quote:

---

Originally posted by WDZ
Looks nice, but IIRC the old code "cached" the selected text for a reason: in some browsers (not sure which ), clicking the button will actually unselect the text before quickquote() has a chance to grab it.

I read that using onmousedown instead of onclick for the button will solve that problem though... :\

---

hm i thought that might have been why, but in a test with IE7 and firefox it seemed fine. probably an IE6 thing...

quote:

---

Originally posted by ShawnZ

quote:

---

Originally posted by Chris UK
Try clearing your cache to get a fresh copy of the JavaScript files and then restart your browser.

---

wtf?! what does that have to do with it? he's obviously just selected his PM text at one point, and his browser is still saying it's selected or something...

---

No. I didn't and never have...

The improved code is online now... I tested it in IE6 and it actually works fine, so that's good enough for me.

@dt: I didn't like how your code omitted the username when quoting selected text, so I removed that "feature."

quote:

---

Originally posted by Chris UK
Try clearing your cache to get a fresh copy of the JavaScript files and then restart your browser.

---

Not really.. this is possibly one of the oldest forum bugs ever..
Quick Quote works in such a way that it allows you to quote the last text for an entire post instead of the entire post ie you can quote only this one line from my post and leave everything else out. For that purpose it checks the selected/last selected text on that page by you.. if that happens to not be the same post as you clicked the quick quote button then.. well it can't do anything (meaning highlighting my post and clicking the quick quote button on say ShawnZ's post would show ShawnZ had said what I did).

Solution is to reselect what you want to actually quote and then click the quick quote button on that person's post.

Oh, ok - didn't know about that bug .